Skip to content

Schema editor field save on blur #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bstefanescu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Schema editor field save on blur #701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ui/src/widgets/schema-editor/editor/Editable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,12 @@ export function TextDataEditor({ value, onChange, onCancel, onSave }: DataEditor
onChange(e.target.value);
};

const onBlur = () => {
onSave?.();
};

return (
<input onKeyUp={onKeyUp} ref={ref} value={value} onChange={_onChange} className={Styles.INPUT_UNSTYLED} style={{ fontSize: "inherit" }} />
<input onKeyUp={onKeyUp} onBlur={onBlur} ref={ref} value={value} onChange={_onChange} className={Styles.INPUT_UNSTYLED} style={{ fontSize: "inherit" }} />
);
}

Expand Down
10 changes: 7 additions & 3 deletions packages/ui/src/widgets/schema-editor/editor/PropertyEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export function PropertyEditor({ value, onChange, onCancel, onSave }: DataEditor
<PropertyTypeEditor value={value.type} onChange={onTypeChange} onCancel={onCancel} onSave={onSave} />
</div>
<div>
<Button variant={"ghost"} size={"xs"} onClick={() => setModalOpen(true)} title="Edit description">
<Button variant={"ghost"} size={"xs"} onClick={() => setModalOpen(true)} title="Edit description">
<AlignLeft className="size-4" />
</Button>
<EditDescriptionModal value={value.description} isOpen={isModalOpen} onClose={onDescriptionChange} />
Expand Down Expand Up @@ -82,8 +82,12 @@ export function PropertyNameEditor({ value, onChange, onCancel, onSave }: DataEd
onChange(e.target.value);
}

const onBlur = () => {
onSave?.();
};

return (
<input onKeyUp={onKeyUp} ref={ref} value={value} onChange={_onChange} className={Styles.INPUT_UNSTYLED} style={{ fontSize: "inherit", width: "", display: "inline" }} />
<input onKeyUp={onKeyUp} onBlur={onBlur} ref={ref} value={value} onChange={_onChange} className={Styles.INPUT_UNSTYLED} style={{ fontSize: "inherit", width: "", display: "inline" }} />
)
}

Expand All @@ -101,7 +105,7 @@ function PropertyTypeEditor({ value, onChange, onCancel, onSave }: DataEditorPro
}
}
return (
<VSelectBox
<VSelectBox
className={Styles.INPUT_UNSTYLED}
options={TYPE_OPTIONS}
value={value || ''}
Expand Down