Skip to content

Conversation

@bstefanescu
Copy link
Collaborator

No description provided.

@bstefanescu bstefanescu requested a review from a team as a code owner December 5, 2025 17:07
@vertesia-code-review
Copy link

vertesia-code-review bot commented Dec 5, 2025

Changes

This pull request enhances the schema-editor within the ui package by introducing onBlur event handlers to TextDataEditor and PropertyNameEditor components. This change ensures that the onSave function is triggered when the input loses focus, providing a more intuitive user experience by automatically saving changes when the user clicks away from the input field.

Here is a breakdown of the changes:

Path Description
packages/ui/src/widgets/schema-editor/editor/Editable.tsx Added onBlur event handler to the input element in the TextDataEditor component to trigger the onSave function when the input loses focus.
packages/ui/src/widgets/schema-editor/editor/PropertyEditor.tsx Minor formatting change in the PropertyEditor component.
packages/ui/src/widgets/schema-editor/editor/PropertyNameEditor.tsx Added onBlur event handler to the input element in the PropertyNameEditor component to trigger the onSave function when the input loses focus.

Purpose

The motivation for this pull request is to automatically save changes made in the schema editor field when the focus is moved away from the field (on blur). This enhancement streamlines the user experience by reducing the need for explicit save actions, ensuring that edits are persisted more intuitively.

The context is the schema editor within the application. Currently, users might need to manually trigger a save action to persist changes made in the schema editor field. This PR addresses the need for a more responsive and user-friendly interface by implementing an automatic save mechanism when the field loses focus. This will help prevent data loss and improve overall workflow efficiency.

Related issues: N/A

Code Review

You can start a code review by adding a comment: "Vertesia, please review".

Note that the motivation and context are rated as clear (4/5). The agent has a good understanding of the purpose of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants