Remove database generation from main function#21
Merged
brendanreardon merged 19 commits intomainfrom Jul 12, 2024
Merged
Conversation
…s global. DB paths separated into two separate ini files
Collaborator
Author
|
All unit tests pass as well as output regression tests. Documentation updated and all changed files have been reviewed. |
Collaborator
Author
|
Attaching zips of output directory used for output regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request and branch is an offshoot of Refactor ini files to be arguments, instead focusing on refactoring the use of the config.ini file instead of both config.ini and colnames.ini. The interpreter version number was increased to 0.7.0 for this pull request.
Additions:
databasesandpreclinicalsections ofconfig.iniwere refactored into their own ini files,annotation-databases.iniandpreclinical-databases.ini, respectively.config.iniandannotation-databases.iniare now required input arguments tomoalmanac.pyandsimplified_input.py, andpreclinical-databases.iniis optional.Revisions:
moalmanac/datasources/was moved to the root directory of the repository,datasources/.moalmanac/moalmanac.pywas updated to accept the config and datasource dictionaries as arguments. As a result of removingconfig.inias a global variable, many functions throughout the codebase now require the config ini to be passed as an argument.moalmanac/README.mdwas updated to reflect the changes to the ini files.config.pytoreader.py.moalmanac/test/datasources_tests.py,moalmanac/test/evaluator_tests.py,moalmanac/test/features_tests.py, andmoalmanac/test/investigator_tests.py.Secondary changes:
moalmanac/run_deconstructSigs.Randmoalmanac/wrapper_deconstructSigs.shfrom repository.run_example.pywas revised to add the date in ISO format to the default output directoryPre-pull request check list,