Merged
Conversation
…ariants, and somatic and germline variants complete
Collaborator
Author
|
All unit tests pass Outputs match by hash when comparing pre- and post- pull request. Attaching outputs from run_example.py. |
Collaborator
Author
|
All files modified have been reviewed. |
Collaborator
Author
|
Uploading an example log here. |
Collaborator
Author
|
Merging pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, we are add logging to the method using the module logging from the Python standard library.
Additions:
.logfile extension. The file will be named based on the --patient_id parameter, for{patient_id}.log. This will provide a timestamped log of what the method is doing.config.inifile now hasgenerate_figuresas an additional toggle within thefunction_togglesection. This will enable or disable figures being generated by moalmanac.Revisions:
config.iniwas increased from 0.7.0 to 0.7.1.--configand--dbsas required arguments, and--preclinical-dbsas an optional argument. Missed in pull request #21.Pre-pull request check list,