Skip to content

Revert "fix: Ignore ComboBox client-side filter in data view items getters (#336)" #8415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vursen merged 5 commits into from
Jan 5, 2026
Merged

Revert "fix: Ignore ComboBox client-side filter in data view items getters (#336)" #8415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
064d64e
Revert "fix: Ignore ComboBox client-side filter in data view items ge…
vursen Jan 2, 2026
93111a4
format code
vursen Jan 2, 2026
b0a9846
remove more wrong tests
vursen Jan 3, 2026
0964a61
format code
vursen Jan 3, 2026
3da9555
Merge branch 'main' into revert-not-working-fix
vursen Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 0 additions & 75 deletions ...tests/src/main/java/com/vaadin/flow/component/combobox/test/ComboBoxLazyDataViewPage.java
View file
Open in desktop

This file was deleted.

16 changes: 1 addition & 15 deletions ...tests/src/main/java/com/vaadin/flow/component/combobox/test/ComboBoxListDataViewPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ public class ComboBoxListDataViewPage extends Div {
static final String SHOW_ITEM_DATA = "showItemData";
static final String SHOW_NEXT_DATA = "showNextData";
static final String SHOW_PREVIOUS_DATA = "showPreviousData";
static final String SHOW_ITEM_COUNT = "showItemCount";
static final String SHOW_ITEMS = "showItems";
static final String AGE_FILTER = "ageFilter";
static final String REMOVE_ITEM = "removeItem";
static final String REVERSE_SORTING = "reverseSorting";
Expand Down Expand Up @@ -96,17 +94,6 @@ public ComboBoxListDataViewPage() {
.getItem(itemSelect.getValue()).getFirstName()));
showItemData.setId(SHOW_ITEM_DATA);

NativeButton showItemCount = new NativeButton("Show Item Count",
click -> count
.setText(String.valueOf(dataView.getItemCount())));
showItemCount.setId(SHOW_ITEM_COUNT);

NativeButton showItems = new NativeButton("Show Items",
click -> itemData
.setText(dataView.getItems().map(Person::toString)
.collect(Collectors.joining(","))));
showItems.setId(SHOW_ITEMS);

// Navigation
NativeButton showNextData = new NativeButton("Next person", event -> {
itemData.setText("Item: " + dataView
Expand Down Expand Up @@ -170,8 +157,7 @@ public ComboBoxListDataViewPage() {

add(comboBox, itemSelect, filterByAge, reverseSorting,
selectItemOnIndex, showItemData, showNextData, showPreviousData,
removePerson, count, itemData, showItemCount, showItems,
secondComboBox);
removePerson, count, itemData, secondComboBox);
}

private List<Person> generatePersonItems() {
Expand Down
174 changes: 0 additions & 174 deletions ...n-tests/src/test/java/com/vaadin/flow/component/combobox/test/ComboBoxLazyDataViewIT.java
View file
Open in desktop

This file was deleted.

Loading