Revert "fix: Ignore ComboBox client-side filter in data view items getters (#336)" #8415
+94
−735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
revert-not-working-fix
branch
from
0c8583f to
064d64e
Compare
vursen
force-pushed
the
revert-not-working-fix
branch
from
153ae5e to
93111a4
Compare
vursen
commented
Jan 3, 2026
| } | ||
|
|
||
| @Test | ||
| public void setFilter_close_filterReset() { |
Contributor
Author
There was a problem hiding this comment.
Added this test to explicitly cover #393 since its coverage was previously ensured implicitly by the integration tests being removed in this PR.
|
DiegoCardoso
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #336 since the solution introduced in that PR didn't resolve the original issue but introduced extra abstractions and tests, see #282 (comment) for details.