-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 리뷰 관리 스크린 상단 탭바 추가하여 대댓글 기준으로 화면 분리 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c5d3eff
fix: getreviewlists 오타 수정
l-lyun 968bd2f
feat: 대댓글을 달지 않은 리뷰 get api 추가
l-lyun e817179
feat: 리뷰 스크린 내 탭바 적용
l-lyun ab2b1b3
feat: 리뷰 컨테이너 refresh 적용
l-lyun 869e44f
fix: review get hooks querykey 변경
l-lyun 3e37a1b
feat: 탭바 이용하여 리뷰 분리
l-lyun 78eebf5
feat: 리뷰 대댓글 작성시 리뷰 쿼리키 갱신
l-lyun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,31 @@ | ||
| import styled from '@emotion/native'; | ||
| import {ToggleButton, ToggleButtonGroup} from '@/components/common'; | ||
|
|
||
| const S = { | ||
| Container: styled.View` | ||
| flex: 1; | ||
| background-color: white; | ||
| `, | ||
|
|
||
| EmptyWrapper: styled.View` | ||
| flex: 1; | ||
| align-items: center; | ||
| `, | ||
|
|
||
| ToggleText: styled.Text` | ||
| color: ${props => props.theme.colors.tertiary}; | ||
| `, | ||
|
|
||
| NavbarGroup: styled(ToggleButtonGroup)` | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-between; | ||
| margin: 10px; | ||
| `, | ||
|
|
||
| ToggleButton: styled(ToggleButton)` | ||
| width: 100%; | ||
| `, | ||
| }; | ||
|
|
||
| export default S; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
무효화할때마다 쿼리키가 무엇인지 api 쿼리를 확인해야되서 약간 불편할 수도 있겠다는 생각이 드네요..
필요하다면 유틸로 묶어서 queryclient를 키를 받고, 쿼리키는 타입추론이 될수있도록 나중에 해보죠
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 해당 부분 쿼리키 훅 만지면서 고민했는데, 프로젝트 사이즈가 더 커지면 형님 말씀해주신 코드 내에서 방법이나,
쿼리키에 대해 문서화를 확실히 해야겠다는 생각이 들었습니다. 코드적으로 어떻게 풀 수 있지?
하고 넘어갔는데 조언 감사합니다~!