feat: 리뷰 관리 스크린 상단 탭바 추가하여 대댓글 기준으로 화면 분리 #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99mini
approved these changes
Aug 20, 2025
Comment on lines
+25
to
+27
| const {onRefresh, refreshing} = usePullDownRefresh(async () => { | ||
| await queryClient.invalidateQueries({ | ||
| queryKey: ['marketList', 'review'], |
Member
There was a problem hiding this comment.
무효화할때마다 쿼리키가 무엇인지 api 쿼리를 확인해야되서 약간 불편할 수도 있겠다는 생각이 드네요..
필요하다면 유틸로 묶어서 queryclient를 키를 받고, 쿼리키는 타입추론이 될수있도록 나중에 해보죠
Contributor
Author
There was a problem hiding this comment.
저도 해당 부분 쿼리키 훅 만지면서 고민했는데, 프로젝트 사이즈가 더 커지면 형님 말씀해주신 코드 내에서 방법이나,
쿼리키에 대해 문서화를 확실히 해야겠다는 생각이 들었습니다. 코드적으로 어떻게 풀 수 있지?
하고 넘어갔는데 조언 감사합니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
리뷰 관리 페이지 내 댓글을 기준으로 분리하였습니다.
스크린샷 (선택)
💬리뷰 요구사항(선택)