Skip to content

Buffer should be in km #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lispandfound merged 1 commit into from
Jan 20, 2026
Merged

Buffer should be in km #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workflow/default_parameters/develop/defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ velocity_model:
version: "2.07"
topo_type: "SQUASHED_TAPERED"
vs30: 500.0
fault_buffer: 2000.0
fault_buffer: 2.0
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

  • min_vs is in km/s (per schema).
  • fault_buffer is in km (per schema).
  • s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

s_wave_velocity: 3500.0
rrup_interpolants:
[
Expand Down
2 changes: 1 addition & 1 deletion workflow/default_parameters/v24_2_2_1/defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ velocity_model:
topo_type: "SQUASHED_TAPERED"
vs30: 500.0
s_wave_velocity: 3500.0
fault_buffer: 2000.0
fault_buffer: 2.0
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

  • min_vs is in km/s (per schema).
  • fault_buffer is in km (per schema).
  • s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

rrup_interpolants:
[
[
Expand Down
2 changes: 1 addition & 1 deletion workflow/default_parameters/v24_2_2_2/defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ velocity_model:
version: "2.07"
topo_type: "SQUASHED_TAPERED"
vs30: 500.0
fault_buffer: 2000.0
fault_buffer: 2.0
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

  • min_vs is in km/s (per schema).
  • fault_buffer is in km (per schema).
  • s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

s_wave_velocity: 3500.0
rrup_interpolants:
[
Expand Down
2 changes: 1 addition & 1 deletion workflow/default_parameters/v24_2_2_4/defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ velocity_model:
version: "2.07"
topo_type: "SQUASHED_TAPERED"
vs30: 500.0
fault_buffer: 2000.0
fault_buffer: 2.0
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

  • min_vs is in km/s (per schema).
  • fault_buffer is in km (per schema).
  • s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

s_wave_velocity: 3500.0
rrup_interpolants:
[
Expand Down
Loading