Buffer should be in km

[lispandfound]

Hotfix for last PR merge, buffer should be in kilometres not metres

[gemini-code-assist]

Summary of Changes

Hello @lispandfound, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a critical hotfix by adjusting the unit of the fault_buffer parameter across multiple environment configuration files. The change ensures that the buffer value is correctly interpreted as kilometers instead of meters, rectifying a unit discrepancy from a prior integration.

Highlights

• Unit Correction: The fault_buffer parameter in several defaults.yaml configuration files has been corrected from meters to kilometers. The value was changed from 2000.0 (representing 2000 meters) to 2.0 (representing 2 kilometers).
• Hotfix Application: This pull request serves as a hotfix to address an incorrect unit interpretation introduced in a previous merge, ensuring the fault_buffer is consistently defined in kilometers as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This pull request corrects a unit inconsistency by converting the fault_buffer parameter from meters to kilometers across all configuration versions. The parameter was incorrectly set to 2000.0 (interpreted as kilometers in the code, which would have created an unreasonably large 2000 km buffer) and is now correctly set to 2.0 km.

Changes:

• Updated fault_buffer from 2000.0 to 2.0 across all default parameter configuration files

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
workflow/default_parameters/v24_2_2_4/defaults.yaml	Corrected fault_buffer from 2000.0 to 2.0 km
workflow/default_parameters/v24_2_2_2/defaults.yaml	Corrected fault_buffer from 2000.0 to 2.0 km
workflow/default_parameters/v24_2_2_1/defaults.yaml	Corrected fault_buffer from 2000.0 to 2.0 km
workflow/default_parameters/develop/defaults.yaml	Corrected fault_buffer from 2000.0 to 2.0 km

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where the fault_buffer parameter was specified in meters instead of kilometers across several default configuration files. The change from 2000.0 to 2.0 aligns with the schema definition, which expects the value in km.

While the fix is correct, it highlights a potential maintainability issue due to inconsistent units within the velocity_model configuration block. I've added comments to the changed files suggesting that units be explicitly documented in the configuration to prevent similar bugs in the future. Despite this, the change itself is correct and addresses the immediate issue.

[gemini-code-assist]

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

• min_vs is in km/s (per schema).
• fault_buffer is in km (per schema).
• s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

[gemini-code-assist]

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

• min_vs is in km/s (per schema).
• fault_buffer is in km (per schema).
• s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

[gemini-code-assist]

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

• min_vs is in km/s (per schema).
• fault_buffer is in km (per schema).
• s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.

[gemini-code-assist]

Thanks for fixing the unit for fault_buffer. This highlights a broader maintainability issue with inconsistent units in this configuration block. The schema (schemas.py) and values suggest a mix of units.

For example:

• min_vs is in km/s (per schema).
• fault_buffer is in km (per schema).
• s_wave_velocity appears to be in m/s, but its schema definition lacks a unit.

This inconsistency can lead to errors. To improve clarity, consider adding comments to specify units for each parameter. A follow-up task to address this would be beneficial.