debian packaging for yaru-theme-cinnamon by hsbasu · Pull Request #3639 · ubuntu/yaru

hsbasu · 2022-05-14T04:38:13Z

debian: Add binary package yaru-theme-cinnamon to d/control
debian: add install script yaru-theme-cinnamon.install
.gitignore: add d/yaru-theme-cinnamon and d/yaru-theme-unity
cinnamon: fix permission of close*.svg assets

hsbasu · 2022-05-14T04:39:54Z

@Jupi007 I guess we missed this part for yaru-theme for cinnamon-shell.

JPeisach · 2022-05-17T17:06:35Z

@Jupi007 I guess we missed this part for yaru-theme for cinnamon-shell.

we intentionally decided to come back to it later

JPeisach

bumping standards-version may mess up other parts of the package; and FYI latest standards ver is 4.6.0.1 (Debian packaging manual)

hsbasu · 2022-05-17T18:19:12Z

bumping standards-version may mess up other parts of the package; and FYI latest standards ver is 4.6.0.1 (Debian packaging manual)

I built it on jammy using debuild and pbuilder and found no errors. I would request if you'd try building it. Anyway we need it, right? So, @ItzSwirlz do you suggest i change the version to 4.6.0.1 or revert it to 4.1.5 keeping this PR. Or should I close it?

JPeisach · 2022-05-28T22:51:14Z

bumping standards-version may mess up other parts of the package; and FYI latest standards ver is 4.6.0.1 (Debian packaging manual)

I built it on jammy using debuild and pbuilder and found no errors. I would request if you'd try building it. Anyway we need it, right? So, @ItzSwirlz do you suggest i change the version to 4.6.0.1 or revert it to 4.1.5 keeping this PR. Or should I close it?

If it is Jammy, 4.6.0.1 has been out long enough before it should be default. See if ''lintian' complaints about it.

hsbasu · 2022-05-29T06:06:44Z

If it is Jammy, 4.6.0.1 has been out long enough before it should be default. See if ''lintian' complaints about it.

I already checked lintian outputs while building in launchpad and found no error. You can check the build outputs here

and shortened output of debuild on my jammy:

Running custom install script '/usr/bin/python3 /home/himadri/Projects/project-mamolinux/Side_projects/my-repos/packages/themes/yaru/cinnamon-shell/src/post_install.py share Yaru default dark'
   dh_install -O--buildsystem=meson
   dh_migrations -O--buildsystem=meson
   dh_installdocs -O--buildsystem=meson
   dh_installchangelogs -O--buildsystem=meson
   dh_installsystemduser -O--buildsystem=meson
   dh_installalternatives -O--buildsystem=meson
   dh_icons -O--buildsystem=meson
   dh_perl -O--buildsystem=meson
   dh_link -O--buildsystem=meson
   dh_strip_nondeterminism -O--buildsystem=meson
   dh_compress -O--buildsystem=meson
   dh_fixperms -O--buildsystem=meson
   dh_missing -O--buildsystem=meson
   dh_installdeb -O--buildsystem=meson
   dh_gencontrol -O--buildsystem=meson
dpkg-gencontrol: warning: Depends field of package yaru-theme-sound: substitution variable ${shlibs:Depends} used, but is not defined
dpkg-gencontrol: warning: Depends field of package yaru-theme-gtk: substitution variable ${shlibs:Depends} used, but is not defined
dpkg-gencontrol: warning: Depends field of package yaru-theme-cinnamon-shell: substitution variable ${shlibs:Depends} used, but is not defined
dpkg-gencontrol: warning: Depends field of package yaru-theme-gnome-shell: substitution variable ${shlibs:Depends} used, but is not defined
dpkg-gencontrol: warning: Depends field of package yaru-theme-unity: substitution variable ${shlibs:Depends} used, but is not defined
dpkg-gencontrol: warning: Depends field of package yaru-theme-icon: substitution variable ${shlibs:Depends} used, but is not defined
   dh_md5sums -O--buildsystem=meson
   dh_builddeb -O--buildsystem=meson
dpkg-deb: building package 'yaru-theme-cinnamon-shell' in '../yaru-theme-cinnamon-shell_22.04.4_all.deb'.
dpkg-deb: building package 'yaru-theme-sound' in '../yaru-theme-sound_22.04.4_all.deb'.
dpkg-deb: building package 'yaru-theme-gtk' in '../yaru-theme-gtk_22.04.4_all.deb'.
dpkg-deb: building package 'yaru-theme-unity' in '../yaru-theme-unity_22.04.4_all.deb'.
dpkg-deb: building package 'yaru-theme-gnome-shell' in '../yaru-theme-gnome-shell_22.04.4_all.deb'.
dpkg-deb: building package 'yaru-theme-icon' in '../yaru-theme-icon_22.04.4_all.deb'.
 dpkg-genbuildinfo --build=binary -O../yaru-theme_22.04.4_amd64.buildinfo
 dpkg-genchanges --build=binary -O../yaru-theme_22.04.4_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 fakeroot debian/rules clean
dh clean --buildsystem=meson --with migrations
   dh_auto_clean -O--buildsystem=meson
   dh_autoreconf_clean -O--buildsystem=meson
   dh_clean -O--buildsystem=meson
 dpkg-source --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)
Now running lintian yaru-theme_22.04.4_amd64.changes ...
Finished running lintian.
Now signing changes and any dsc files...
 signfile buildinfo yaru-theme_22.04.4_amd64.buildinfo Marco Trevisan (Treviño) <marco@ubuntu.com>
gpg: skipped "Marco Trevisan (Treviño) <marco@ubuntu.com>": No secret key
gpg: /tmp/debsign.Ozpb153U/yaru-theme_22.04.4_amd64.buildinfo: clear-sign failed: No secret key
debsign: gpg error occurred!  Aborting....

And screenshot from gdebi

hsbasu · 2022-08-19T14:41:31Z

@Jupi007 @ItzSwirlz A gentle reminder for further review.

JPeisach · 2022-08-19T19:15:13Z

Oh jeez, I'm sorry!

Quick look over everything - LGTM!

Jupi007 · 2022-08-20T10:03:09Z

I'm sorry @hsbasu I had completely forgotten your PR.
I added some comments :)

hsbasu · 2022-08-20T12:59:44Z

So, can this be merged now or needs some improvements?

Jupi007 · 2022-08-20T13:16:05Z

Please look at my two review comments :)

hsbasu · 2022-08-20T15:43:32Z

Please look at my two review comments :)

@Jupi007 Sorry, but I couldn't find any. Where did you put them? I think I should change the debian standard to 4.6.1 as can be found here.

debian/control

Jupi007 · 2022-08-20T15:49:09Z

Sorry I didn't sent them 😅

hsbasu · 2022-08-20T16:46:35Z

@Jupi007 I have resolved all of them and the PR is ready to merge.

Jupi007

LGFM 👍
Thanks @hsbasu

I just ask a little review of @Muqtxdir and then merging :)

Jupi007 · 2022-08-23T11:35:37Z

@jbicha Can you review this please?

jbicha · 2022-08-23T11:56:57Z

I suggest closing this merge request.

yaru-theme is now packaged in Debian so I think new features for Debian/Ubuntu packaging should be reported to Debian either to the Debian bug tracker or as merge request on Salsa.

Jupi007 · 2022-08-23T12:08:10Z

But it will still be useful to merge this PR, as we have a debian packaging CI check in this repo.

jbicha · 2022-08-23T12:36:13Z

Maybe you shouldn't have debian/ packaging here?

(except for the ubuntu/* branches where it's used for SRUs for releases before 22.10)

Jupi007 · 2022-08-23T12:38:04Z

That would be nice to drop debian packaging from here, but then we'll lost the CI check.

hsbasu · 2022-08-24T03:34:53Z

@jbicha I have a question. You mentioned that debian is packaging yaru. Have they already created the yaru-theme-cinnamon binary?

If they haven't then I think this PR will be useful. They can just merge it from upstream. Isn't it?

Update: I checked the link you provided. Debian doesn't create the yaru-theme-cinnamon binary.

hsbasu · 2022-09-28T17:48:47Z

@Jupi007 I think I should close this PR and submit one on salsa just like @jbicha suggested. What do you think?

Jupi007 · 2022-09-28T17:51:14Z

Mhh, I don't know honestly 😅
@3v1n0 What do you think of this?

hsbasu · 2022-09-28T18:42:54Z

Created a merge request here. There are a few minor improvements attached to this PR. I'd remove the packaging part with git commit --amend after the PR at Debian is merged. So that the other improvements can still be merged. Is that fine @Jupi007 @ItzSwirlz @jbicha ?

Jupi007 · 2022-09-28T18:49:54Z

There are a few minor improvements attached to this PR. I'd remove the packaging part with git commit --amend after the PR at Debian is merged. So that the other improvements can still be merged.

I'm fine with this, but maybe create another PR with these fixes, and keep this one in case, for the cinnamon debian packaging.

Initu-Castilhos · 2023-08-27T04:13:47Z

When this p.r. will it be implemented?

- debian: Add binary package yaru-theme-cinnamon to d/control - debian: add install script yaru-theme-cinnamon.install - .gitignore: add d/yaru-theme-cinnamon and d/yaru-theme-unity

hsbasu · 2023-08-27T06:09:49Z

@Jupi007 Gentle reminder for debian packaging. I have removed the conflicting files.

Jupi007

LGTM, but I'd like to have @3v1n0 opinion on this.

hsbasu · 2023-11-03T03:04:22Z

@jbicha can you review and merge the PR here, so that we'll have yaru-theme-cinnamon before noble?

N.B: This is my first time contributing to debian directly. Please let me know if I need to follow any rules to create a PR to debian.

JPeisach reviewed May 17, 2022

View reviewed changes

Jupi007 requested changes Aug 20, 2022

View reviewed changes

debian/control Outdated Show resolved Hide resolved

debian/control Outdated Show resolved Hide resolved

hsbasu force-pushed the yaru-theme-cinnamon-shell branch 2 times, most recently from b0bd634 to fc0fa9d Compare August 20, 2022 16:44

hsbasu changed the title ~~debian packaging for yaru-theme-cinnamon-shell~~ debian packaging for yaru-theme-cinnamon Aug 20, 2022

hsbasu requested a review from Jupi007 August 20, 2022 16:45

Jupi007 approved these changes Aug 21, 2022

View reviewed changes

Jupi007 requested review from Muqtxdir and removed request for Muqtxdir August 21, 2022 12:02

Jupi007 added Area: cinnamon Area: packaging labels Aug 30, 2022

hsbasu mentioned this pull request Mar 15, 2023

Prepare cinnamon theme variants #3842

Merged

debian packaging for yaru-theme-cinnamon

030c223

- debian: Add binary package yaru-theme-cinnamon to d/control - debian: add install script yaru-theme-cinnamon.install - .gitignore: add d/yaru-theme-cinnamon and d/yaru-theme-unity

hsbasu force-pushed the yaru-theme-cinnamon-shell branch from fc0fa9d to 030c223 Compare August 27, 2023 06:08

Jupi007 approved these changes Aug 27, 2023

View reviewed changes

JPeisach approved these changes Sep 6, 2023

View reviewed changes

Conversation

hsbasu commented May 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hsbasu commented May 14, 2022

Uh oh!

JPeisach commented May 17, 2022

Uh oh!

JPeisach left a comment

Choose a reason for hiding this comment

Uh oh!

hsbasu commented May 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JPeisach commented May 28, 2022

Uh oh!

hsbasu commented May 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hsbasu commented Aug 19, 2022

Uh oh!

JPeisach commented Aug 19, 2022

Uh oh!

Jupi007 commented Aug 20, 2022

Uh oh!

hsbasu commented Aug 20, 2022

Uh oh!

Jupi007 commented Aug 20, 2022

Uh oh!

hsbasu commented Aug 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Jupi007 commented Aug 20, 2022

Uh oh!

hsbasu commented Aug 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jupi007 left a comment

Choose a reason for hiding this comment

Uh oh!

Jupi007 commented Aug 23, 2022

Uh oh!

jbicha commented Aug 23, 2022

Uh oh!

Jupi007 commented Aug 23, 2022

Uh oh!

jbicha commented Aug 23, 2022

Uh oh!

Jupi007 commented Aug 23, 2022

Uh oh!

hsbasu commented Aug 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hsbasu commented Sep 28, 2022

Uh oh!

Jupi007 commented Sep 28, 2022

Uh oh!

hsbasu commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jupi007 commented Sep 28, 2022

Uh oh!

Initu-Castilhos commented Aug 27, 2023

Uh oh!

hsbasu commented Aug 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jupi007 left a comment

Choose a reason for hiding this comment

Uh oh!

hsbasu commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

hsbasu commented May 14, 2022 •

edited

Loading

hsbasu commented May 17, 2022 •

edited

Loading

hsbasu commented May 29, 2022 •

edited

Loading

hsbasu commented Aug 20, 2022 •

edited

Loading

hsbasu commented Aug 20, 2022 •

edited

Loading

hsbasu commented Aug 24, 2022 •

edited

Loading

hsbasu commented Sep 28, 2022 •

edited

Loading

hsbasu commented Aug 27, 2023 •

edited

Loading

hsbasu commented Nov 3, 2023 •

edited

Loading