Prepare cinnamon theme variants

[hsbasu]

• set cinnamon component option to true
• add colorable assets file
• Update the meson build script to create variants
• Follow the way gnome-shell variants are created
• Not using directories cinnamon, cinnamon-dark, dark and default. Can be cleaned up later.

[hsbasu]

Hi @Jupi007 The PR for cinnamon variants you requested. Please have a look. Looking at this, I think we should merge #3639 here. Because, we don't know when debian will merge my PR.

[Initu-Castilhos]

The light version has a lot of contrast between the separator and the corner bar.

The dark version is ok.

The checked and radio are 24px and the radio is light in the dark version. Take a look at this P.R. done: #3794

[Jupi007]

Hi @hsbasu and thanks a lot for this PR!
This is much appreciated ❤️

I added some requested change.

[Jupi007]

The light version has a lot of contrast between the separator and the corner bar.

@Initu-Castilhos Is this problem reproducible in master, or only in this PR?

[Jupi007]

@hsbasu Thanks a lot to have applied my requested changes 🙂
I don't know why, but it looks like you messed up the commits because some of my previous PRs changes pop up here 🤔

@Initu-Castilhos Can you retest this PR, please?
I need to setup a cinnamon VM, but it could be nice to have a quicker feedback, especially for the separator problem.

[Initu-Castilhos]

@hsbasuMuito obrigado por ter aplicado minhas alterações solicitadas🙂 Não sei por que, mas parece que você estragou os commits porque algumas das minhas alterações anteriores de PRs apareceram aqui🤔

@Initu-CastilhosVocê pode testar novamente este PR, por favor? Preciso configurar uma VM canela, mas seria bom ter um feedback mais rápido, especialmente para o problema do separador.
👍🏼

[Initu-Castilhos]

A versão light tem muito contraste entre o separador e a barra de canto.

@Initu-CastilhosEste problema é reproduzível em master, ou apenas neste PR?

Master.

[hsbasu]

@hsbasu Thanks a lot to have applied my requested changes 🙂
I don't know why, but it looks like you messed up the commits because some of my previous PRs changes pop up here 🤔

@Initu-Castilhos Can you retest this PR, please?
I need to setup a cinnamon VM, but it could be nice to have a quicker feedback, especially for the separator problem.

Yes I know. Give me some time. I'll repush it. Please don't merge yet.

[Initu-Castilhos]

@hsbasuMuito obrigado por ter aplicado minhas alterações solicitadas ligeiramente_smiling_face
Não sei por que, mas parece que você estragou os commits porque algumas das minhas alterações anteriores de PRs apareceram aqui pensando
@Initu-CastilhosVocê pode testar novamente este PR, por favor?
Preciso configurar uma VM canela, mas seria bom ter um feedback mais rápido, especialmente para o problema do separador.

Sim eu sei. Me dê um tempo. Vou repô-lo. Por favor, não mescle ainda.

The problem still exists.

[Initu-Castilhos]

It's not coloring.

[Initu-Castilhos]

Maybe it's better to change the color of the panel and base it on the titlebar color like in Mint-Y. I think this makes it better to maintain the theme.

[hsbasu]

@Initu-Castilhos @Jupi007 @ItzSwirlz Corrected everything. Please have a look.

[Initu-Castilhos]

Nothing yet.

[hsbasu]

Nothing yet.

It's strange. I rebased all the scss files from the default folder. I was able to generate all the variants and assets properly. Let me try again.

[hsbasu]

@Initu-Castilhos @Jupi007 I get it now. Those colours are coming from the sass files and are not using accent_bg_colour as their base. To modify those colours, the sass files need to be modified. I have cross checked all the colorizable assests are taking accent colour. I would suggest to have a separate commit for them.

[Initu-Castilhos]

@Initu-Castilhos @Jupi007Agora eu entendi. Essas cores vêm dos arquivos sass e não estão usando acent_bg_colour como base. Para modificar essas cores, os arquivos sass precisam ser modificados. Eu verifiquei se todos os recursos colorizáveis ​​estão usando cores de destaque. Eu sugeriria ter um commit separado para eles.

I found this project: https://github.com/dgsasha/dg-yaru

This style with floating menu and more rounded corners is very close to gnome-shell.

[hsbasu]

@Jupi007 A gentle reminder on the PR.

[Jupi007]

Hi @hsbasu,
sorry for the late reply.

Imo, this can be merged.
But I would like to have @Muqtxdir approval before.

[Muqtxdir]

thanks

[Jupi007]

Thanks a lot for this PR @hsbasu 👍
And sorry for the delay.

[hsbasu]

@Jupi007 It's ok. Glad to contribute.

[Jupi007]

@hsbasu it is already merged 🙂

[Feichtmeier]

:D

[hsbasu]

😁 didn't see that it's already merged. Good work everyone.

[Initu-Castilhos]

It does not complete the installation.

[Jupi007]

@Initu-Castilhos I did a fix PR here: #3921
Can you test it?