Skip field Initialization when a Motif scope class is created#269
Merged
Skip field Initialization when a Motif scope class is created#269
Conversation
rysh88
force-pushed
the
feature_disable_field_init_v3
branch
4 times, most recently
from
e1605cc to
e1fafcc
Compare
rysh88
force-pushed
the
feature_disable_field_init_v3
branch
from
e1fafcc to
52e8aaf
Compare
rysh88
force-pushed
the
feature_disable_field_init_v3
branch
from
52e8aaf to
49d6e95
Compare
|
Reviewed by @TonyTangAndroid and Yohan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scope class uses volatile variables to retain the dependencies. Volatile variables are much more expensive than normal variables and write operations are especially more expensive by 5~10 times. The scope class initializes all the fields as soon as it's constructed. The scope class will cause an ANR or performance degradation if it contains many dependencies when it's created.
The suggested change will be assigned a value of null instead of INITIALIZED and making the scope class initialization more lightweight and it also reduces the atomic write/read operations