Revise the test code to audit the second revision based on e1fafcc0#13
Merged
TonyTangAndroid merged 1 commit intomainfrom Aug 11, 2025
Merged
Revise the test code to audit the second revision based on e1fafcc0#13TonyTangAndroid merged 1 commit intomainfrom
TonyTangAndroid merged 1 commit intomainfrom
Conversation
TonyTangAndroid
commented
Aug 11, 2025
Comment on lines
-39
to
-41
| if (_bar == Initialized.INITIALIZED) { | ||
| return null; | ||
| } |
Owner
Author
There was a problem hiding this comment.
Now those unnecessary code has been deleted
Comment on lines
+34
to
+36
| if (_bar == null) { | ||
| throw new NullPointerException("Factory method cannot return null"); | ||
| } |
Owner
Author
There was a problem hiding this comment.
It is motif spec that null is not supported in factory method
There was a problem hiding this comment.
We can return null if we don't have the null annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.