Add specialized linear layout for decoupling capacitor partitions (#15)#31
Open
AouIssa wants to merge 1 commit intotscircuit:mainfrom
Open
Add specialized linear layout for decoupling capacitor partitions (#15)#31AouIssa wants to merge 1 commit intotscircuit:mainfrom
AouIssa wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
@AouIssa is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
PackSolver2scatters decoupling capacitors in messy irregular patterns instead of arranging them in clean horizontal rows like professional schematics.Solution
Early-return in
SingleInnerPartitionPackingSolver._step()whenpartitionType === "decoupling_caps"— bypassesPackSolver2and arranges caps in a horizontal row viacreateLinearDecouplingCapLayout().Zero impact on non-decoupling partitions.
Results
Two separate partitions arranged by voltage rail:
Partition 1 (V3_3 + GND): C12, C13, C14, C15, C19, C8 — all Y=-5.956, gaps exactly 0.2mm
Partition 2 (V1_1 + GND): C18, C7 — all Y=-1.953, gap exactly 0.2mm
Visual Proof
SVG snapshot tests included using
bun-match-svg:Demo video attached below.
Tests
bun run format:checkcleantsc --noEmitcleanAddresses feedback from PRs #27 and #28 regarding visual snapshot testing.
/claim #15
decoupling-caps-demo.mp4