fix: Specialized Layout for Decoupling Capacitors#30
Open
GhadiSaab wants to merge 1 commit intotscircuit:mainfrom
Open
fix: Specialized Layout for Decoupling Capacitors#30GhadiSaab wants to merge 1 commit intotscircuit:mainfrom
GhadiSaab wants to merge 1 commit intotscircuit:mainfrom
Conversation
Implements createDecouplingCapsLayout() method to create clean linear arrangements for decoupling capacitor partitions instead of messy layouts. Changes: - Added detection logic for partitionType === 'decoupling_caps' - Implemented createDecouplingCapsLayout() with linear layout algorithm - Layout orientation (horizontal/vertical) based on chip aspect ratio - Consistent spacing using decouplingCapsGap or chipGap fallback - Deterministic ordering by sorting chips by ID - Centered result at (0, 0) - Added tests for decoupling caps layout functionality Fixes tscircuit#15
|
@GhadiSaab is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a specialized linear layout for decoupling capacitor partitions to make them less messy.
Changes
partitionType === 'decoupling_caps'createDecouplingCapsLayout()method with clean linear arrangementTesting
Fixes #15
/claim #15