Skip to content

widen error for log likelihood decrease #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdc10 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

widen error for log likelihood decrease #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions emu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,9 @@ def expectation_maximization_iterations(log_p_rgs, db_ids, lli_thresh, input_thr
raise ValueError("f sums to {}, rather than 1".format(freq_sum))

# confirm log likelihood increase
log_likelihood_diff = updated_log_likelihood - total_log_likelihood
log_likelihood_diff = round(updated_log_likelihood, 2) - round(total_log_likelihood, 2)
total_log_likelihood = updated_log_likelihood
if log_likelihood_diff < 0:
if log_likelihood_diff < -1:
raise ValueError("total_log_likelihood decreased from prior iteration")

# exit loop if log likelihood increase less than threshold
Expand Down Expand Up @@ -686,7 +686,7 @@ def combine_outputs(dir_path, rank, split_files=False, count_table=False):
return df_combined_full

if __name__ == "__main__":
__version__ = "3.4.5"
__version__ = "3.4.6"
parser = argparse.ArgumentParser()
parser.add_argument('--version', '-v', action='version', version='%(prog)s v' + __version__)
subparsers = parser.add_subparsers(dest="subparser_name", help='sub-commands')
Expand Down