Skip to content

Make auction page visible to all users and default landing page #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansmiley merged 1 commit into from
Mar 8, 2026
Merged

Make auction page visible to all users and default landing page #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions frontend/src/lib/components/appSideBar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,18 +268,17 @@
{/snippet}
</Sidebar.MenuButton>
</Sidebar.MenuItem>
{#if serverState.isAdmin && serverState.sudoEnabled}
<Sidebar.MenuItem>
<Sidebar.MenuButton>
{#snippet child({ props })}
<a href="/auction" {...props} onclick={handleClick}>
<Gavel />
<span class="ml-3">Auction</span>
</a>
{/snippet}
</Sidebar.MenuButton>
</Sidebar.MenuItem>
{/if}
<Sidebar.MenuItem>
<Sidebar.MenuButton>
{#snippet tooltipContent()}Auction{/snippet}
{#snippet child({ props })}
<a href="/auction" {...props} onclick={handleClick}>
<Gavel />
<span class="ml-3">Auction</span>
</a>
{/snippet}
</Sidebar.MenuButton>
</Sidebar.MenuItem>
<Sidebar.MenuItem>
<Sidebar.MenuButton>
{#snippet tooltipContent()}Docs{/snippet}
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/routes/+page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { redirect } from '@sveltejs/kit';

export function load() {
redirect(307, '/market');
redirect(307, '/auction');
}
12 changes: 3 additions & 9 deletions frontend/src/routes/auction/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<script lang="ts">
import { goto } from '$app/navigation';
import CreateAuction from '$lib/components/forms/createAuction.svelte';
import AuctionLink from '$lib/components/auctionLink.svelte';
import AuctionModal from '$lib/components/auctionModal.svelte';
Expand All @@ -8,13 +7,6 @@

let selectedAuction: websocket_api.IAuction | null = $state(null);

// Redirect to /market unless admin with sudo enabled
$effect(() => {
if (serverState.actingAs !== undefined && !(serverState.isAdmin && serverState.sudoEnabled)) {
goto('/market');
}
});

// Close the modal if the selected auction is deleted
$effect(() => {
if (selectedAuction && !serverState.auctions.has(selectedAuction.id!)) {
Expand All @@ -25,7 +17,9 @@

<div class="mr-auto flex flex-col gap-8 pt-8">
<h1 class="text-xl font-bold">Auction</h1>
<CreateAuction />
{#if serverState.isAdmin && serverState.sudoEnabled}
<CreateAuction />
{/if}

<div class="grid grid-cols-1 gap-6 sm:grid-cols-2 md:grid-cols-3 lg:grid-cols-4">
{#each Array.from(serverState.auctions.values()).sort((a, b) => (a.transactionTimestamp?.seconds ?? 0) - (b.transactionTimestamp?.seconds ?? 0)) as auction}
Expand Down