Skip to content

Zultron/2022 09 19 rebase for PRs: 2 minor ros#15

Merged
zultron merged 7 commits intotormach:foxy-develfrom
zultron:zultron/2022-09-19-rebase_for_PRs-2-minor-ROS
Sep 22, 2022
Merged

Zultron/2022 09 19 rebase for PRs: 2 minor ros#15
zultron merged 7 commits intotormach:foxy-develfrom
zultron:zultron/2022-09-19-rebase_for_PRs-2-minor-ROS

Conversation

@zultron
Copy link
Copy Markdown
Collaborator

@zultron zultron commented Sep 19, 2022

This is 2 of 9 in a series of PRs refactoring the hw_device_mgr to run outside ROS, handle file resources more intelligently, manage PDO configurations, improve abstraction, improve CiA402 homing, simplify initialization, fix a state_cmd race condition, and other fixes and improvements.

This PR is based on & should be merged after #14 .

This second PR makes changes related to ROS:

  • Add plain Python logging class for use outside of ROS
  • When a test can't import rclpy, skip those tests for use outside of ROS
  • Convert to ament_python ROS package; reduces LOC; packaging shared with non-ROS use cases
  • Fix forgotten ROS1 code left in non-ROS manager update loop

Copy link
Copy Markdown
Contributor

@kylc kylc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error when building. Maybe something just got out of order in the PRs?

--- stderr: hw_device_mgr                                                                                                                        
package init file 'hw_device_mgr/devices/device_xml/__init__.py' not found (or not a regular file)
---

Otherwise looks good!

Fixup for PR tormach#14 commit f6c516c, "setup.py:  Add device_xml package
resources to install"
@zultron zultron force-pushed the zultron/2022-09-19-rebase_for_PRs-2-minor-ROS branch from e8c6214 to a37e813 Compare September 22, 2022 18:46
@zultron
Copy link
Copy Markdown
Collaborator Author

zultron commented Sep 22, 2022

Thanks, @kylc , you got it, devices/device_xml/__init__.py should have made it into PR #14, but was added in PR #16 instead. I re-added it here. Merging....

@zultron zultron merged commit e43369c into tormach:foxy-devel Sep 22, 2022
@zultron zultron deleted the zultron/2022-09-19-rebase_for_PRs-2-minor-ROS branch November 3, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants