Zultron/2022 09 19 rebase for PRs: 2 minor ros#15
Merged
zultron merged 7 commits intotormach:foxy-develfrom Sep 22, 2022
Merged
Conversation
…-19-rebase_for_PRs-2-minor-ROS
kylc
approved these changes
Sep 21, 2022
Contributor
kylc
left a comment
There was a problem hiding this comment.
I'm getting this error when building. Maybe something just got out of order in the PRs?
--- stderr: hw_device_mgr
package init file 'hw_device_mgr/devices/device_xml/__init__.py' not found (or not a regular file)
---
Otherwise looks good!
Fixup for PR tormach#14 commit f6c516c, "setup.py: Add device_xml package resources to install"
e8c6214 to
a37e813
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is 2 of 9 in a series of PRs refactoring the
hw_device_mgrto run outside ROS, handle file resources more intelligently, manage PDO configurations, improve abstraction, improve CiA402 homing, simplify initialization, fix astate_cmdrace condition, and other fixes and improvements.This PR is based on & should be merged after #14 .
This second PR makes changes related to ROS:
loggingclass for use outside of ROSrclpy, skip those tests for use outside of ROSament_pythonROS package; reduces LOC; packaging shared with non-ROS use cases