Cylindrical to Cartesian

.ci_fedora.sh

@@ -41,8 +41,9 @@ then
     # Ignore weak depencies
     echo "install_weak_deps=False" >> /etc/dnf/dnf.conf
     echo "minrate=10M" >> /etc/dnf/dnf.conf
+    export FORCE_COLUMNS=200
     time dnf -y install dnf5
-    time dnf5 -y install dnf5-plugins cmake python3-zoidberg python3-natsort
+    time dnf5 -y install dnf5-plugins cmake python3-zoidberg python3-natsort python3-boututils
     # Allow to override packages - see #2073
     time dnf5 copr enable -y davidsch/fixes4bout || :
     time dnf5 -y upgrade

.github/workflows/clang-format.yml

@@ -22,7 +22,8 @@ jobs:
 
       - name: Run clang-format
         id: format
-        run: git clang-format origin/${{ github.base_ref }}
+        run:
+          while ! git clang-format origin/${{ github.base_ref }} ; do git add . ; done
 
       - name: Commit to the PR branch
         uses: stefanzweifel/git-auto-commit-action@v5

.github/workflows/clang-tidy-review.yml

@@ -22,10 +22,9 @@ jobs:
           submodules: true
 
       - name: Run clang-tidy
-        uses: ZedThree/clang-tidy-review@v0.19.0
+        uses: ZedThree/clang-tidy-review@v0.21.0
         id: review
         with:
-          annotations: true
           build_dir: build
           apt_packages: "libfftw3-dev,libnetcdf-c++4-dev,libopenmpi-dev,petsc-dev,slepc-dev,liblapack-dev,libparpack2-dev,libsundials-dev,uuid-dev"
           config_file: ".clang-tidy"
@@ -48,4 +47,4 @@ jobs:
                              -DBOUT_UPDATE_GIT_SUBMODULE=OFF
 
       - name: Upload clang-tidy fixes
-        uses: ZedThree/clang-tidy-review/upload@v0.19.0
+        uses: ZedThree/clang-tidy-review/upload@v0.21.0

.github/workflows/tests.yml

@@ -208,8 +208,8 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: Build Fedora rawhide
-        run: ./.ci_fedora.sh setup openmpi rawhide
+      - name: Build Fedora
+        run: ./.ci_fedora.sh setup openmpi latest
         shell: bash
         env:
           TRAVIS_BUILD_DIR: ${{ github.workspace }}

cmake/FindnetCDF.cmake

@@ -32,6 +32,7 @@ if (NOT netCDF_ROOT AND EXISTS "${BOUT_USE_NETCDF}")
   set(netCDF_ROOT "${BOUT_USE_NETCDF}")
 endif()
 
+enable_language(C)
 find_package(netCDF QUIET CONFIG)
 
 if (netCDF_FOUND)

cmake/SetupBOUTThirdParty.cmake

@@ -272,6 +272,7 @@ option(BOUT_DOWNLOAD_SUNDIALS "Download and build SUNDIALS" OFF)
 cmake_dependent_option(BOUT_USE_SUNDIALS "Enable support for SUNDIALS time solvers" OFF
   "NOT BOUT_DOWNLOAD_SUNDIALS" ON)
 if (BOUT_USE_SUNDIALS)
+  enable_language(C)
   if (BOUT_DOWNLOAD_SUNDIALS)
     message(STATUS "Downloading and configuring SUNDIALS")
     include(FetchContent)
@@ -293,7 +294,6 @@ if (BOUT_USE_SUNDIALS)
     FetchContent_MakeAvailable(sundials)
     message(STATUS "SUNDIALS done configuring")
   else()
-    enable_language(C)
     find_package(SUNDIALS REQUIRED)
     if (SUNDIALS_VERSION VERSION_LESS 4.0.0)
       message(FATAL_ERROR "SUNDIALS_VERSION 4.0.0 or newer is required. Found version ${SUNDIALS_VERSION}.")