Cylindrical to Cartesian #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure this does not crash if coordinates or transform is not set. In this case no FCI transformation is set, and this returns false.
Add isFci also to mesh
…eview Fix clang tidy review
CI: Show more output of dnf5 to help debugging
Adds an option phi_boundary_relax. If set to true, then the radial boundary conditions on the potential phi are relaxed over a given timescale towards zero gradient. Adapted from Hermes-3 (https://github.com/boutproject/hermes-3/blob/master/src/vorticity.cxx#L261).
Should average over Z
Use structs to group together arrays for boundary row elimination. Coefficients from HypreMatrix are stored in one struct, using a shared_ptr to share values with vectors. Eliminated boundary row values need to be passed from RHS to solution vector. This now uses a shared pointer that will manage the HypreFree call.
Reads cell center coordinates from the mesh, and saves to the output. This is to facilitate code coupling and visualisation.
Update copyright statement, contact email.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Changed C free functions to be members of BCMatrixEquations. Clang formatted, minor style changes. Test results unchanged.
Difficult to see the test results amongst the log outputs. Now pipe the logs and save to files.
Bumps [ZedThree/clang-tidy-review](https://github.com/zedthree/clang-tidy-review) from 0.20.1 to 0.21.0. - [Release notes](https://github.com/zedthree/clang-tidy-review/releases) - [Changelog](https://github.com/ZedThree/clang-tidy-review/blob/master/CHANGELOG.md) - [Commits](ZedThree/clang-tidy-review@v0.20.1...v0.21.0) --- updated-dependencies: - dependency-name: ZedThree/clang-tidy-review dependency-version: 0.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…review Bump ZedThree/clang-tidy-review from 0.20.1 to 0.21.0
* next: Bump ZedThree/clang-tidy-review from 0.20.1 to 0.21.0 Use std::filesystem::path for inputs Handle absolute paths to options file
…ariable naming convention.
…aster Cmake fix from master
…lash Fix name clash in some examples and MMS tests
SNES solver: Added a PID controller to update the timestep
Added comments to explain why the coloring may be non-symmetric around an X-point.
…metric snes: Print a warning if the coloring is non-symmetric.
…o fake_mesh_fixture.hxx
tomc271
force-pushed
the
cylindrical-to-cartesian
branch
from
32fafaf to
b512667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method CylindricalCoordinatesToCartesian() on TokamakOptions class, which returns Cartesian coordinates x, y, z (as Field3D objects) calculated from the cylindrical coordinates Rxy and Zxy (Field2D objects) together with nz equally spaced points for the values of the toroidal angle.