Skip to content

ci: fix agnocast ci#422

Open
mojomex wants to merge 13 commits intomainfrom
ci/fix-agnocast-env-var-name
Open

ci: fix agnocast ci#422
mojomex wants to merge 13 commits intomainfrom
ci/fix-agnocast-env-var-name

Conversation

@mojomex
Copy link
Collaborator

@mojomex mojomex commented Mar 19, 2026

PR Type

  • Bug Fix

Related Links

Description

This PR fixes the build-and-test(-differential) CI for the Agnocast case.

There were multiple issues:

  • The env var was mistakenly named AGNOCAST_ENABLED but was supposed to be ENABLE_AGNOCAST. As a result, even the Agnocast case did not build/test with Agnocast, hiding potential issues.
  • Agnocast kmod and heaphook were not installed when Agnocast was enabled
  • The LD_PRELOAD and AGNOCAST_MEMPOOL_SIZE env vars were not being set

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex self-assigned this Mar 19, 2026
@mojomex mojomex changed the title Ci/fix agnocast env var name ci: fix agnocast env var name Mar 19, 2026
mojomex added 2 commits March 19, 2026 16:40
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex mojomex force-pushed the ci/fix-agnocast-env-var-name branch from e107abc to ccc7aef Compare March 19, 2026 07:40
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.34%. Comparing base (baf4f92) to head (8960408).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   48.34%   48.34%           
=======================================
  Files         156      156           
  Lines       12996    12997    +1     
  Branches     6900     6901    +1     
=======================================
+ Hits         6283     6284    +1     
  Misses       5326     5326           
  Partials     1387     1387           
Flag Coverage Δ
nebula_hesai 31.54% <ø> (?)
total 48.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojomex mojomex changed the title ci: fix agnocast env var name ci: fix agnocast ci Mar 19, 2026
mojomex added 11 commits March 19, 2026 17:32
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…cast PPA

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…up script

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
…ript

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant