Skip to content

d10_1038_s41591_018_0096_5 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
LisaSikkema wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

d10_1038_s41591_018_0096_5 #192

LisaSikkema wants to merge 7 commits into from

Conversation

@LisaSikkema
Copy link

@LisaSikkema LisaSikkema commented Mar 15, 2021

Adding data loader for data from https://www.nature.com/articles/s41591-018-0096-5 based on later publication (2020 Qian et al., cell research) which had clean count matrices of same data published here: http://blueprint.lambrechtslab.org/#/099de49a-cd68-4db1-82c1-cc7acd3c6d14/*/welcome.

@review-notebook-app
Copy link

review-notebook-app bot commented Mar 15, 2021

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@davidsebfischer davidsebfischer changed the base branch from master to dev March 15, 2021 10:33
@davidsebfischer
Copy link
Contributor

davidsebfischer commented Mar 15, 2021

Thanks @LisaSikkema! The init file cannot be empty but must be:

FILE_PATH = __file__

@LisaSikkema
Copy link
Author

LisaSikkema commented Mar 15, 2021

okay the init file was automatically generated, maybe good to specify somewhere what it needs to look like? or did I miss that documentation

@davidsebfischer
Copy link
Contributor

davidsebfischer commented Mar 15, 2021

okay the init file was automatically generated, maybe good to specify somewhere what it needs to look like? or did I miss that documentation

@Zethson ?

@Zethson
Copy link
Member

Zethson commented Mar 15, 2021 •
edited
Loading

okay the init file was automatically generated, maybe good to specify somewhere what it needs to look like? or did I miss that documentation

Yeah, I didn't know that it was supposed to be non-empty. I will fix that and it will simply include the required line from now on.
Sorry!

edit: fixed :)

@LisaSikkema
Copy link
Author

LisaSikkema commented May 3, 2021

Hey! Nothing more to do from my side here, right?

@LisaSikkema
Copy link
Author

LisaSikkema commented Feb 4, 2022

Can this one be merged?

@le-ander le-ander marked this pull request as draft February 14, 2022 10:42
@le-ander le-ander changed the title Lambrechts data d10_1038_s41591_018_0096_5 Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davidsebfischer davidsebfischer davidsebfischer requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dataset

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LisaSikkema @davidsebfischer @Zethson @le-ander