Skip to content

allow testing katello from a branch#1157

Merged
jeremylenz merged 1 commit intodevelopfrom
katello-branch
Feb 24, 2026
Merged

allow testing katello from a branch#1157
jeremylenz merged 1 commit intodevelopfrom
katello-branch

Conversation

@evgeni
Copy link
Member

@evgeni evgeni commented Feb 24, 2026

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Build:

  • Make the Katello gem source branch configurable through the KATELLO_BRANCH environment variable.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configures the Katello gem dependency to select its GitHub branch via the KATELLO_BRANCH environment variable, defaulting to master when not set.

Flow diagram for Katello gem branch selection via environment variable

flowchart TD
    A[Bundle install / app boot] --> B[Evaluate katello gem source]
    B --> C{Is KATELLO_BRANCH set?}
    C -->|Yes| D[Use katello GitHub repo branch KATELLO_BRANCH]
    C -->|No| E[Use katello GitHub repo branch master]
    D --> F[Katello gem resolved]
    E --> F[Katello gem resolved]
Loading

File-Level Changes

Change Details Files
Make the Katello gem use an environment-variable-controlled branch instead of a hard-coded master branch.
  • Replaced the hard-coded 'master' branch specification for the Katello gem with an ENV.fetch lookup.
  • Defaulted the Katello gem branch to 'master' when the KATELLO_BRANCH environment variable is not present.
gemfile.d/katello.rb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jeremylenz
Copy link
Collaborator

I have PTSD from relying on environment variables, but I guess this is fine since it's not production :)

@jeremylenz jeremylenz merged commit a499cc5 into develop Feb 24, 2026
18 checks passed
@jeremylenz jeremylenz deleted the katello-branch branch February 24, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants