Add foreman_rh_cloud CI tests to catch breaking changes early#11648
Merged
jeremylenz merged 3 commits intoKatello:masterfrom Feb 24, 2026
Merged
Add foreman_rh_cloud CI tests to catch breaking changes early#11648jeremylenz merged 3 commits intoKatello:masterfrom
jeremylenz merged 3 commits intoKatello:masterfrom
Conversation
This adds a new non-blocking workflow that runs foreman_rh_cloud tests against Katello PRs. This will help catch breaking changes before they are merged, similar to how Foreman tests Katello. The workflow is non-blocking (indicated by the workflow name) so foreman_rh_cloud test failures won't prevent Katello PRs from merging, but developers will be notified of potential issues. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider narrowing the
pull_requesttrigger (e.g., usingpathsor specific branches) if running dependent plugin tests on every PR is unnecessary, to avoid wasting CI resources. - The
concurrency.groupkey is just${{ github.ref_name }}-dependent-plugins; if other workflows use a similar pattern, you may want to include the workflow name or file name to avoid unintended cross-workflow cancellations.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider narrowing the `pull_request` trigger (e.g., using `paths` or specific branches) if running dependent plugin tests on every PR is unnecessary, to avoid wasting CI resources.
- The `concurrency.group` key is just `${{ github.ref_name }}-dependent-plugins`; if other workflows use a similar pattern, you may want to include the workflow name or file name to avoid unintended cross-workflow cancellations.
## Individual Comments
### Comment 1
<location path=".github/workflows/dependent_plugins.yml" line_range="5-12" />
<code_context>
+ group: ${{ github.ref_name }}-dependent-plugins
+ cancel-in-progress: true
+
+jobs:
+ foreman_rh_cloud:
+ name: foreman_rh_cloud
+ uses: theforeman/actions/.github/workflows/foreman_plugin.yml@v0
</code_context>
<issue_to_address>
**🚨 suggestion (security):** Workflow is missing an explicit permissions block, which defaults to broad write access.
GitHub Actions issues a broad token by default. Please add a top-level `permissions:` block and restrict it to the minimum needed (likely `contents: read`, unless this reusable workflow requires more) to limit impact if a job step is compromised.
```suggestion
push:
branches:
- 'master'
- 'KATELLO-*'
permissions:
contents: read
concurrency:
group: ${{ github.ref_name }}-dependent-plugins
cancel-in-progress: true
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
|
This won't checkout the Katello PR, so won't test what you wanted to test. (No, I have no idea how to quickly implement what you want) |
Member
|
Let's see if theforeman/foreman_rh_cloud#1157 helps |
Member
|
@jeremylenz okay, that seems to work, but I thought rh cloud is busted right now? |
Member
Author
theforeman/foreman_rh_cloud#1156 should theoretically have un-busted it. |
0cb7aa0 to
2fa4ba8
Compare
evgeni
approved these changes
Feb 24, 2026
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new non-blocking workflow that runs foreman_rh_cloud tests against Katello PRs. This will help catch breaking changes before they are merged, similar to how Foreman tests Katello.
The workflow is non-blocking (indicated by the workflow name) so foreman_rh_cloud test failures won't prevent Katello PRs from merging, but developers will be notified of potential issues.
Summary by Sourcery
CI: