Skip to content

feature: extend dict get value with _#16

Open
lfkdsk wants to merge 2 commits intothautwarm:masterfrom
lfkdsk:feature-add-exdict-support
Open

feature: extend dict get value with _#16
lfkdsk wants to merge 2 commits intothautwarm:masterfrom
lfkdsk:feature-add-exdict-support

Conversation

@lfkdsk
Copy link

@lfkdsk lfkdsk commented Dec 5, 2019

No description provided.

@lfkdsk
Copy link
Author

lfkdsk commented Dec 5, 2019

@thautwarm

Copy link
Owner

@thautwarm thautwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this extension makes sense...
z_x means z['x']...

@lfkdsk
Copy link
Author

lfkdsk commented Dec 9, 2019

@thautwarm
If I want to implement the full Exdict function, you need to modify the Parser module, so you find a workaround. mmmm can be turned off if you don't think good

@thautwarm
Copy link
Owner

Rewrite the source code to Python's at here? https://github.com/thautwarm/moshmosh/blob/master/moshmosh/extension.py#L109

I think the current design needs improvements for better abstractions.

@lfkdsk
Copy link
Author

lfkdsk commented Dec 9, 2019

@thautwarm just like string-replace-like macro ?
But,ast.Parser is be called before it (https://github.com/thautwarm/moshmosh/blob/master/moshmosh/extension.py#L223), so non-official python syntax is not supported under the current design.

@thautwarm
Copy link
Owner

@lfkdsk Oh, yes... This does need a better design...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants