Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/lib/pages/schedules.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -87,30 +87,36 @@
const onError = (err: APIErrorResponse) => {
error = err?.body?.message || translate('schedules.error-message-fetching');
};

const showFilters = $derived(Number($schedulesCount) > 0 || query);
</script>

<div class="flex flex-col gap-4">
<h1 class="flex flex-col gap-0 md:flex-row md:items-center md:gap-2">
<SchedulesCount />
</h1>
<div class="flex flex-col justify-between gap-2 md:flex-row">
{#if Number($schedulesCount) > 0 || query}
<div
class="flex flex-col gap-2 md:flex-row {showFilters
? 'justify-between'
: 'justify-end'}"
>
{#if showFilters}
<SearchAttributeFilter
bind:filters={$scheduleFilters}
{searchAttributeOptions}
refresh={() => {
refresh = Date.now();
}}
/>
{#if !createDisabled}
<Button
data-testid="create-schedule"
href={routeForScheduleCreate({ namespace })}
disabled={!writeActionsAreAllowed()}
>
{translate('schedules.create')}
</Button>
{/if}
{/if}
{#if !createDisabled}
<Button
data-testid="create-schedule"
href={routeForScheduleCreate({ namespace })}
disabled={!writeActionsAreAllowed()}
>
{translate('schedules.create')}
</Button>
{/if}
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/schedules.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ test.describe('Schedules Page', () => {
await scheduleButton.click();
await expect(page).toHaveURL(/schedules/);
const createScheduleButton = page.getByTestId('create-schedule');
await expect(createScheduleButton).toBeVisible();
await createScheduleButton.click();
await expect(createScheduleButton.first()).toBeVisible();
await createScheduleButton.first().click();
await expect(page).toHaveURL(/create/);

await page.getByTestId('schedule-name-input').fill('e2e-schedule-1');
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/disable-write-actions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@ test.describe('Disable write actions on empty schedules list actions', () => {
const namespace = page.locator('h1');
await expect(namespace).toHaveText('0 Schedules');
const createButton = page.getByTestId('create-schedule');
await expect(createButton).toBeDisabled();
await expect(createButton.first()).toBeDisabled();
});
});
2 changes: 1 addition & 1 deletion tests/integration/schedule-edit.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ test.describe('Schedules List with schedules', () => {
await page.waitForResponse(SCHEDULES_COUNT_API);

const createButton = page.getByTestId('create-schedule');
await expect(createButton).toBeEnabled();
await expect(createButton.first()).toBeEnabled();

const scheduleLink = page.getByRole('link', { name: /test-schedule/i });
await expect(scheduleLink).toBeVisible();
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/schedules-list.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ test.describe('Schedules List with no schedules', () => {
await expect(namespace).toHaveText('0 Schedules');

const createButton = page.getByTestId('create-schedule');
await expect(createButton).toBeEnabled();
await expect(createButton.first()).toBeEnabled();
});
});

Expand Down
Loading