Skip to content

always show create schedule button when 0 schedules#3205

Merged
rossedfort merged 5 commits intomainfrom
fix-create-schedules-not-showing
Feb 27, 2026
Merged

always show create schedule button when 0 schedules#3205
rossedfort merged 5 commits intomainfrom
fix-create-schedules-not-showing

Conversation

@rossedfort
Copy link
Contributor

Description & motivation 💭

Always show the Create Schedule button in the top header of the schedules page, even if the schedule count is 0. Note this means there will be 2 create schedules buttons when there are 0 schedules, but will fix a temporary issue caused by inc-1541-2026-02-27-error-in-getting-schedule-count

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@rossedfort rossedfort requested a review from a team as a code owner February 27, 2026 17:07
@rossedfort rossedfort requested review from rossnelson and removed request for a team February 27, 2026 17:07
@vercel
Copy link

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 27, 2026 5:55pm

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 27, 2026

Warnings
⚠️

📊 Strict Mode: 1 error in 1 file (0.1% of 1110 total)

src/lib/pages/schedules.svelte (1)
  • L127:5: Type '(err: APIErrorResponse) => void' is not assignable to type '(error: unknown) => void | undefined'.

Generated by 🚫 dangerJS against 7b6164a

@rossedfort
Copy link
Contributor Author

Screenshot 2026-02-27 at 10 11 49 AM

Copy link
Contributor

@KATIETOLER KATIETOLER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Ross, thanks so much for getting this done so quickly!!

@laurakwhit laurakwhit mentioned this pull request Feb 27, 2026
3 tasks
@rossedfort
Copy link
Contributor Author

Screenshot 2026-02-27 at 10 49 33 AM Pic of dupe buttons which is OK for now

@rossedfort rossedfort merged commit 115e9f4 into main Feb 27, 2026
16 checks passed
@rossedfort rossedfort deleted the fix-create-schedules-not-showing branch February 27, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants