-
Notifications
You must be signed in to change notification settings - Fork 2
Support for Sphinx 9 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Sphinx 9 #170
Conversation
WalkthroughUpdates project dependencies to support Sphinx 9 by loosening the sphinx-design version constraint from an exact pin to a flexible range. Also includes changelog documentation and removes minor formatting inconsistencies. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 10 10
Lines 594 594
=======================================
Hits 563 563
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The RTD build run using Sphinx v9.1.0 and myst v5.0.0 is hitting two kinds of warnings, one from Python and one from Sphinx / docutils. -- https://app.readthedocs.org/projects/sphinx-design-elements/builds/31079757/#302672396--14 -- https://app.readthedocs.org/projects/sphinx-design-elements/builds/31079757/#302672396--50 NB: I am just documenting the hiccup diligently so that others in the same or a similar boat can find related problems when updating to Sphinx 9, and hopefully find a solution right away within this PR. |
|
The second warning was mitigated with 685f0ce. 🪂 |
... effectively enabling support for Sphinx 9.
WARNING: Transition must be child of <document> or <section>. [docutils]
| `hyper-navigate`, `hyper-open`, `hyper-tutorial`, `hyper-read-more`, | ||
| `hyper-readme-github`, `hyper-nb-colab`, `hyper-nb-binder`, `hyper-nb-github`. | ||
|
|
||
| --- | ||
|
|
||
| {hyper-navigate}`https://example.org` | ||
| {hyper-open}`https://example.org` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That spot raised this Sphinx warning, effectively failing the build because we are using -W --keep-going across the board?
WARNING: Transition must be child of <document> or <section>. [docutils]
About
Make the package support Sphinx 9 by permitting installation of sphinx-design 0.7.0. Thank you, @chrisjsewell!
References