Skip to content

Dependencies: Permit installation of Sphinx 9.x #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amotl merged 3 commits into from
Jan 21, 2026
Merged

Dependencies: Permit installation of Sphinx 9.x #671

amotl merged 3 commits into from
Jan 21, 2026

Conversation

@amotl
Copy link
Member

@amotl amotl commented Dec 19, 2025 •
edited
Loading

@amotl
Copy link
Member Author

amotl commented Dec 19, 2025 •
edited
Loading

Observation

CI still selects Sphinx 8.x.

Reason

Dependencies are not compatible with Sphinx 9 yet.

furo==2025.9.25 depends on sphinx>=6.0,<9.0
sphinx-design==0.6.1 depends on sphinx>=6,<9

@amotl amotl requested review from seut and surister December 19, 2025 02:46
@amotl amotl mentioned this pull request Dec 19, 2025
Merged
@amotl amotl removed request for seut and surister December 19, 2025 03:27
@amotl
Copy link
Member Author

amotl commented Jan 4, 2026 •
edited
Loading

Furo 2025.12.19 is now compatible with Sphinx 9.

sphinx-design needs an update of MyST-Parser.

@amotl
Copy link
Member Author

amotl commented Jan 20, 2026 •
edited
Loading

sphinx-design 0.7.0 was released yesterday, now also including support for Sphinx 9.
This patch will unlock relevant updates:

@coderabbitai

This comment was marked as spam.

Sign in to view
@amotl amotl mentioned this pull request Jan 20, 2026
Merged
@amotl amotl force-pushed the sphinx9 branch 2 times, most recently from ca16739 to 6bd37db Compare January 21, 2026 05:42
This was referenced Jan 21, 2026
Closed
Closed
@amotl amotl requested review from seut and removed request for seut January 21, 2026 06:20
@amotl amotl marked this pull request as ready for review January 21, 2026 06:21
@amotl amotl requested review from matriv and seut January 21, 2026 06:22
matriv
matriv approved these changes Jan 21, 2026
View reviewed changes
Copy link

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, left a question.
Would be great to test github.com/crate/crate docs are building correctly after this change, thx!

docs/conf.py
intersphinx_mapping["sde"] = ("https://sphinx-design-elements.readthedocs.io/en/latest/", None)


linkcheck_ignore += [
Copy link

@matriv matriv Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this required?

Copy link
Member Author

@amotl amotl Jan 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some project-local rate limiting against github.com when building the docs here.

@amotl
Copy link
Member Author

amotl commented Jan 21, 2026

Would be great to test github.com/crate/crate docs are building correctly after this change, thx!

The unlocking of Sphinx 9 has been successfully validated on those downstream projects using the pre-release package crate-docs-theme==0.47.1.dev5.

@amotl amotl merged commit 1781583 into main Jan 21, 2026
9 checks passed
@amotl amotl deleted the sphinx9 branch January 21, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matriv matriv matriv approved these changes

@seut seut Awaiting requested review from seut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amotl @matriv