Fix IndexError when coverage reports extensionless files#261
Open
reese-allison wants to merge 1 commit intotarpas:mainfrom
Open
Fix IndexError when coverage reports extensionless files#261reese-allison wants to merge 1 commit intotarpas:mainfrom
reese-allison wants to merge 1 commit intotarpas:mainfrom
Conversation
When coverage.py reports files without extensions (Dockerfile, Makefile, etc.),
SourceTree.get_file() crashes with IndexError because rsplit(".", 1) returns
a single-element list when there's no dot in the filename.
Handle the case by checking for a dot before attempting to extract the extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When coverage.py reports files without extensions (e.g.,
Dockerfile,Makefile),SourceTree.get_file()crashes:at
testmon/testmon_core.pyline 93.Cause:
filename.rsplit(".", 1)returns a single-element list when the filename has no dot, so[1]raises IndexError.Fix: Check for the presence of a dot before attempting to extract the extension.
Reproduction: Create a test that calls
compile()with an extensionless filename, then runpytest --testmon.