Consolidate monorepo go modules, clean-up duplicate files, and fix linter errors

agents/native/artifact.go

@@ -69,7 +69,7 @@ func cacheFile(uri *uri) (*ArtifactReference, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer fOrig.Close()
+	defer func() { _ = fOrig.Close() }()
 
 	hasher := sha256.New()
 	if _, err := io.Copy(hasher, fOrig); err != nil {
@@ -113,7 +113,7 @@ func cacheObjectStoreArtifact(uri *uri, nc *nats.Conn) (*ArtifactReference, erro
 	if err != nil {
 		return nil, err
 	}
-	defer fCache.Close()
+	defer func() { _ = fCache.Close() }()
 
 	_, err = fCache.Write(bin_b)
 	if err != nil {

agents/native/artifact_test.go

@@ -29,7 +29,7 @@ func createTestBinary(t testing.TB, tmpDir string) (string, string, int) {
 	if err != nil {
 		t.Errorf("Failed to write to Go file: %v", err)
 	}
-	f.Close()
+	be.NilErr(t, f.Close())
 
 	// Command to compile the Go code into a binary
 	// go build -trimpath -ldflags="-buildid= -X 'main.buildTime=static_time'"
@@ -116,7 +116,7 @@ func TestArtifactNats(t *testing.T) {
 	be.Equal(t, binHash, ref.Digest)
 	be.Equal(t, binLen, ref.Size)
 
-	os.RemoveAll(tDir)
+	be.NilErr(t, os.RemoveAll(tDir))
 }
 
 func TestArtifactFile(t *testing.T) {
@@ -139,7 +139,7 @@ func TestArtifactFile(t *testing.T) {
 	be.Equal(t, binHash, ref.Digest)
 	be.Equal(t, binLen, ref.Size)
 
-	os.RemoveAll(workingDir)
+	be.NilErr(t, os.RemoveAll(workingDir))
 }
 
 const testProg string = `package main

agents/native/state.go

@@ -16,9 +16,9 @@ import (
 	"time"
 
 	"github.com/nats-io/nats.go"
-	"github.com/synadia-io/nex/sdk/go/agent"
 	"github.com/synadia-io/nex/internal"
 	"github.com/synadia-io/nex/models"
+	"github.com/synadia-io/nex/sdk/go/agent"
 )
 
 type nexletState struct {
@@ -300,7 +300,7 @@ func (n *nexletState) RemoveWorkload(namespace, workloadId string) error {
 		w.SetState(models.WorkloadStateStopping)
 		n.Unlock()
 
-		err := stopProcess(w.Process)
+		err := internal.StopProcess(w.Process)
 		// this will hit if the process is already stopped
 		if errors.Is(err, os.ErrProcessDone) {
 			n.logger.Debug("process already exited", slog.String("workloadId", workloadId), slog.String("namespace", namespace))

client/client_benchmark_test.go

@@ -72,11 +72,12 @@ func BenchmarkClientAuction(b *testing.B) {
 			ctx := b.Context()
 
 			nexNodes := _test.StartNexus(b, ctx, server.ClientURL(), tc.clusterSize, false)
-			defer func() {
+			defer func(b *testing.B) {
 				for _, nn := range nexNodes {
-					nn.Shutdown()
+					shutdownErr := nn.Shutdown()
+					b.Logf("failed to shutdown nex node: %s", shutdownErr)
 				}
-			}()
+			}(b)
 			nc.Close()
 
 			// open a new fresh connection for the nex client