Add react tip button by shapkarin · Pull Request #32 · superhero-com/superhero-utils

shapkarin · 2020-10-22T12:52:49Z

closes #21

davidyuk

I don't think that all environments will support es6 imports, classes, and arrow functions, so proposing to pass button-react through webpack.

src/button-react/index.js

package.json

src/button-react/index.js

davidyuk · 2020-10-27T11:52:34Z

@shapkarin Any response to the first comment about es6 features and webpack?

shapkarin · 2020-10-28T14:15:46Z

@shapkarin Any response to the first comment about es6 features and webpack?

@davidyuk I will add

davidyuk

Document this feature in the README, please.

button-react.js

webpack.config.js

shapkarin · 2020-11-06T06:26:17Z

Document this feature in the README, please.

Added basic version.

README.md

package.json

webpack.config.js

davidyuk · 2020-11-16T12:43:11Z

package.json

+    "prop-types": "^15.7.2",
+    "react": "^17.0.0"


Currently, these dependencies are inlined into the bundle, let's use externals to keep them extracted.

I hope that will help with that, I will add it

externals: { 'prop-types': 'prop-types', 'react': 'react' },

The general idea is not to hope but to test it using a bundle analyzer and trying to use it in different environments

I will check it at Monday's morning

shapkarin · 2020-11-17T00:34:49Z

@davidyuk squashed into one commit, please check this PR

davidyuk

Not all issues from the last review are resolved

webpack.config.js

davidyuk

In general, this PR looks fine, but there is one thing related to the documentation that I would like to check before merging this. I will come back later to this PR.

webpack.config.js

shapkarin · 2020-11-25T08:30:20Z

@davidyuk fixed and I clean build folder and run it once again, looks that all is fine. I will change commits history today.

Update webpack.config.js Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com> again temporary commit just to track fix README.md anchor links fix genConfig option name

Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>

davidyuk

In #38 I have implemented a more general approach with additional examples allowing to test that. Proposing to close this and merge that instead.

davidyuk · 2020-11-30T06:20:37Z

src/button-react.js

+    super(props);
+    this.button = React.createRef();
+    this.componentDidMount = this.componentDidUpdate = () =>
+      createButton(this.button.current, this.props);


While working on #38 I have found that the replacement of the DOM node breaks subsequent component updates. I have fixed it there by using a different API.

davidyuk · 2020-11-30T06:22:16Z

webpack.config.js

  target: 'web',
+  externals: {
+    'prop-types': 'prop-types',
+    'react': 'react'


Actually, this is not working if imported using the script tag because React exposes itself there as React, it is fixed in #38

shapkarin requested review from davidyuk and mradkov October 22, 2020 12:52

davidyuk reviewed Oct 22, 2020

View reviewed changes

src/button-react/index.js Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/button-react/index.js Outdated Show resolved Hide resolved

shapkarin force-pushed the feature/button-react branch from dee983f to 08db3a4 Compare October 26, 2020 05:58

shapkarin force-pushed the feature/button-react branch from 08db3a4 to 1913fef Compare October 29, 2020 11:49

shapkarin requested a review from davidyuk October 29, 2020 11:50

shapkarin force-pushed the feature/button-react branch from 1913fef to 99acccc Compare October 29, 2020 11:51

mradkov mentioned this pull request Oct 29, 2020

Update readme version to 0.5.1 #34

Merged

davidyuk requested changes Nov 4, 2020

View reviewed changes

button-react.js Show resolved Hide resolved

webpack.config.js Outdated Show resolved Hide resolved

shapkarin force-pushed the feature/button-react branch 2 times, most recently from f04111c to ff038ad Compare November 11, 2020 13:18

shapkarin requested a review from davidyuk November 11, 2020 13:18

davidyuk requested changes Nov 16, 2020

View reviewed changes

shapkarin requested a review from davidyuk November 16, 2020 13:52

add react tip button

b94c723

shapkarin force-pushed the feature/button-react branch from 7f2c602 to b94c723 Compare November 17, 2020 00:34

davidyuk mentioned this pull request Nov 19, 2020

Server side rendering aeternity/superhero-ui#871

Closed

davidyuk reviewed Nov 19, 2020

View reviewed changes

webpack.config.js Outdated Show resolved Hide resolved

davidyuk reviewed Nov 25, 2020

View reviewed changes

webpack.config.js Outdated Show resolved Hide resolved

webpack.config.js Outdated Show resolved Hide resolved

Yury Shapkarin and others added 2 commits November 25, 2020 17:38

fix README.md anchor links and genConfig option name

a5003c9

Update webpack.config.js Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com> again temporary commit just to track fix README.md anchor links fix genConfig option name

Update webpack.config.js

8d69c79

Co-authored-by: Denis Davidyuk <denis_davidyuk@hotmail.com>

shapkarin force-pushed the feature/button-react branch from 3884062 to 8d69c79 Compare November 25, 2020 14:39

shapkarin mentioned this pull request Nov 30, 2020

button: Fix rendering in Safari, refactor styles #37

Merged

shapkarin requested a review from davidyuk November 30, 2020 03:41

davidyuk mentioned this pull request Nov 30, 2020

Add React and Vue components, examples, and docs #38

Merged

davidyuk reviewed Nov 30, 2020

View reviewed changes

shapkarin closed this Dec 2, 2020

Conversation

shapkarin commented Oct 22, 2020 • edited by davidyuk Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidyuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidyuk commented Oct 27, 2020

Uh oh!

shapkarin commented Oct 28, 2020

Uh oh!

davidyuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shapkarin commented Nov 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidyuk Nov 16, 2020

Choose a reason for hiding this comment

Uh oh!

shapkarin Nov 16, 2020

Choose a reason for hiding this comment

Uh oh!

davidyuk Nov 19, 2020

Choose a reason for hiding this comment

Uh oh!

shapkarin Nov 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shapkarin commented Nov 17, 2020

Uh oh!

davidyuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidyuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shapkarin commented Nov 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidyuk left a comment

Choose a reason for hiding this comment

Uh oh!

davidyuk Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

davidyuk Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shapkarin commented Oct 22, 2020 •

edited by davidyuk

Loading

shapkarin Nov 21, 2020 •

edited

Loading

shapkarin commented Nov 25, 2020 •

edited

Loading