Skip to content

Server side rendering#871

Closed
shapkarin wants to merge 16 commits intodevelopfrom
feature/ssr_vuejs
Closed

Server side rendering#871
shapkarin wants to merge 16 commits intodevelopfrom
feature/ssr_vuejs

Conversation

@shapkarin
Copy link
Copy Markdown
Contributor

No description provided.

@shapkarin shapkarin requested review from CedrikNikita, davidyuk and mradkov and removed request for CedrikNikita November 3, 2020 09:27
Copy link
Copy Markdown
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the current problem with @akryum/vue-cli-plugin-ssr?
I have tried to enable ssr in the example app, it works ok:
davidyuk/reproductions@1474d4e

@shapkarin shapkarin changed the title Prerender-spa-plugin Server side rendering Nov 5, 2020
src/App.vue Outdated
setInterval(() => this.reloadData(), 120 * 1000);
EventBus.$on('backendError', () => this.$route.name !== 'maintenance' && this.$router.push({
name: 'maintenance',
}).catch((err) => { console.error(err); }));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that you have restored a different version of App.vue 🤷‍♀️

Copy link
Copy Markdown
Contributor Author

@shapkarin shapkarin Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, reverted to the current one from the develop branch

@davidyuk
Copy link
Copy Markdown
Member

Almost all is ready - only need to define a route somehow, connect cli plugin and Vue app
Server itself is works

Which route?

Looks like there is actually needs to define new env variable with root route.

I can't get why you need to define BASE_URL

I would like to help you, but I can't start the project because of the obvious error that you have not fixed from the last time:

$ npm run ssr:serve

> superhero-ui@0.2.1 ssr:serve /Users/denis/Documents/superhero-ui
> vue-cli-service ssr:serve

(node:20850) UnhandledPromiseRejectionWarning: Error: args must be an array of arguments

@shapkarin
Copy link
Copy Markdown
Contributor Author

@davidyuk I mixed up with different tools because of pretty the same name and my sickness. Will do my best at Monday.

@shapkarin shapkarin requested a review from davidyuk November 17, 2020 01:19
Copy link
Copy Markdown
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is still is not working, how can I help? Try to make the backend to don't return "Cannot GET /" by disabling as much as possible of our code. After that continuously revert them back resolving issues that will apperar.

@shapkarin
Copy link
Copy Markdown
Contributor Author

@davidyuk can you please share yours suggestion about the current error: Cannot GET / ?

@davidyuk
Copy link
Copy Markdown
Member

let's continue work in #908

@davidyuk davidyuk closed this Jan 16, 2021
@davidyuk davidyuk deleted the feature/ssr_vuejs branch January 16, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants