Skip to content

fix: remove dedupe + add dev react runtime #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caio-pizzol merged 1 commit into from
Nov 27, 2025
Merged

fix: remove dedupe + add dev react runtime #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions demo/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,5 @@ import path from 'path';

export default defineConfig({
plugins: [react()],
base: '/',
resolve: {
alias: {
'superdoc/dist/style.css': path.resolve(__dirname, '../node_modules/superdoc/dist/style.css')
},
dedupe: ['react', 'react-dom', 'react/jsx-runtime']
}
base: '/'
Comment on lines 5 to +7
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore React dedupe in demo Vite config

Removing resolve.dedupe from the demo config means the demo now loads two React instances: the app uses demo/node_modules/react while the locally linked @superdoc-dev/template-builder (demo/package.json link:../.) resolves react from the repo root’s devDependencies. When the demo runs (pnpm dev or pnpm build inside demo), React will detect the double copy and throw the “Invalid hook call” error as soon as hooks render. Keeping resolve.dedupe for react, react-dom, and react/jsx-runtime avoids the duplicate runtime that the previous version prevented.

Useful? React with 👍 / 👎.

});
2 changes: 1 addition & 1 deletion vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default defineConfig({
fileName: (format) => (format === 'es' ? 'index.mjs' : 'index.js'),
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', 'superdoc'],
external: ['react', 'react-dom', 'react/jsx-runtime', 'react/jsx-dev-runtime', 'superdoc'],
},
},
plugins: [
Expand Down
Loading