fix: remove dedupe + add dev react runtime #20
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export default defineConfig({ | ||
| plugins: [react()], | ||
| base: '/', | ||
| resolve: { | ||
| alias: { | ||
| 'superdoc/dist/style.css': path.resolve(__dirname, '../node_modules/superdoc/dist/style.css') | ||
| }, | ||
| dedupe: ['react', 'react-dom', 'react/jsx-runtime'] | ||
| } | ||
| base: '/' |
There was a problem hiding this comment.
Removing resolve.dedupe from the demo config means the demo now loads two React instances: the app uses demo/node_modules/react while the locally linked @superdoc-dev/template-builder (demo/package.json link:../.) resolves react from the repo root’s devDependencies. When the demo runs (pnpm dev or pnpm build inside demo), React will detect the double copy and throw the “Invalid hook call” error as soon as hooks render. Keeping resolve.dedupe for react, react-dom, and react/jsx-runtime avoids the duplicate runtime that the previous version prevented.
Useful? React with 👍 / 👎.
|
🎉 This PR is included in version 0.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.