feat: adaptive insert table column width #1533
Open
+91
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
caio-pizzol
requested review from
afn,
artem-harbour,
harbournick and
luccas-harbour
afn
reviewed
Dec 15, 2025
Comment on lines
+557
to
+558
| // Page dimensions are in inches, convert to pixels (96 PPI) | ||
| const availableWidth = (pageWidth - left - right) * 96; |
|
|
||
| for (let index = 0; index < colsCount; index++) { | ||
| const cell = createCell(types.tableCell, cellContent); | ||
| const cellAttrs = columnWidths ? { colwidth: [columnWidths[index]] } : null; |
Contributor
There was a problem hiding this comment.
What happens if columnWidths.length != colsCount? In particular, if columnWidths[index] is undefined, should cellAttrs be set to null rather than { colwidth: [undefined] }?
| * const table = createTable(schema, 3, 3, false, null, [200, 100, 200]) | ||
| */ | ||
| export const createTable = (schema, rowsCount, colsCount, withHeaderRow, cellContent = null) => { | ||
| export const createTable = (schema, rowsCount, colsCount, withHeaderRow, cellContent = null, columnWidths = null) => { |
Contributor
There was a problem hiding this comment.
Recommend changing function signature to take an object with named options, rather than an ordered list of positional arguments; with a long list of arguments, it's hard to look at a createTable call and understand what each argument is.
harbournick
force-pushed
the
main
branch
2 times, most recently
from
84f8ea5 to
2a443d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.