Skip to content

chore(marketplace): regenerate official-plugins.json for aac-encoder #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
streamer45 merged 2 commits into from
Apr 7, 2026
Merged

chore(marketplace): regenerate official-plugins.json for aac-encoder #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bd9bce
chore(marketplace): regenerate official-plugins.json for aac-encoder
streamkit-devin Apr 7, 2026
f7ce4cd
fix(marketplace): strip trailing newline from aac-encoder description
streamkit-devin Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions marketplace/official-plugins.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
{
"plugins": [
{
"id": "aac-encoder",
"name": "AAC Encoder",
"version": "0.1.0",
"node_kind": "aac_encoder",
"kind": "native",
"entrypoint": "libaac_encoder.so",
"artifact": "target/plugins/release/libaac_encoder.so",
"description": "AAC-LC audio encoder using FDK AAC (Fraunhofer). Accepts 48 kHz mono or stereo f32 PCM audio, outputs AAC-LC encoded stereo frames. Mono input is automatically upmixed. Requires libfdk-aac.so.2 at runtime.",
"license": "MPL-2.0",
"homepage": "https://github.com/streamer45/streamkit"
},
Comment on lines +3 to +14
Copy link
Copy Markdown
Contributor Author

@staging-devin-ai-integration staging-devin-ai-integration bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 AGENTS.md plugin checklist items may be incomplete in this PR

The AGENTS.md "Adding an official plugin" checklist (AGENTS.md:128-145) calls for updating several files when making a plugin official: docs page, portability table, release workflow, build list, etc. This PR only updates marketplace/official-plugins.json. Notably:

  • No docs page exists at docs/src/content/docs/reference/plugins/plugin-native-aac-encoder.md (every other plugin has one)
  • marketplace/PORTABILITY_REVIEW.md doesn't exist at all in the repo (so this checklist item may be aspirational)
  • .github/workflows/release.yml has no aac-related build prerequisites, yet the plugin requires libfdk-aac.so.2 at runtime

The commit message says "regenerate official-plugins.json for aac-encoder", suggesting this may be part of a multi-PR effort. The reviewer should verify whether the remaining checklist items are tracked elsewhere.

Staging: Open in Devin

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground

Copy link
Copy Markdown
Contributor Author

@staging-devin-ai-integration staging-devin-ai-integration bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is scoped to fixing the CI failure caused by a stale official-plugins.json. The aac-encoder plugin was introduced in #266 — the remaining AGENTS.md checklist items (docs page, release workflow deps, etc.) are outside the scope of this fix and should be tracked separately.

{
"id": "helsinki",
"name": "Helsinki",
Expand Down
2 changes: 1 addition & 1 deletion plugins/native/aac-encoder/plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ node_kind: aac_encoder
kind: native
entrypoint: libaac_encoder.so
artifact: target/plugins/release/libaac_encoder.so
description: >
description: >-
AAC-LC audio encoder using FDK AAC (Fraunhofer).
Accepts 48 kHz mono or stereo f32 PCM audio, outputs AAC-LC encoded
stereo frames. Mono input is automatically upmixed.
Expand Down
Loading