chore(marketplace): regenerate official-plugins.json for aac-encoder#267
chore(marketplace): regenerate official-plugins.json for aac-encoder#267streamer45 merged 2 commits intomainfrom
Conversation
Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
| { | ||
| "id": "aac-encoder", | ||
| "name": "AAC Encoder", | ||
| "version": "0.1.0", | ||
| "node_kind": "aac_encoder", | ||
| "kind": "native", | ||
| "entrypoint": "libaac_encoder.so", | ||
| "artifact": "target/plugins/release/libaac_encoder.so", | ||
| "description": "AAC-LC audio encoder using FDK AAC (Fraunhofer). Accepts 48 kHz mono or stereo f32 PCM audio, outputs AAC-LC encoded stereo frames. Mono input is automatically upmixed. Requires libfdk-aac.so.2 at runtime.\n", | ||
| "license": "MPL-2.0", | ||
| "homepage": "https://github.com/streamer45/streamkit" | ||
| }, |
There was a problem hiding this comment.
🚩 AGENTS.md plugin checklist items may be incomplete in this PR
The AGENTS.md "Adding an official plugin" checklist (AGENTS.md:128-145) calls for updating several files when making a plugin official: docs page, portability table, release workflow, build list, etc. This PR only updates marketplace/official-plugins.json. Notably:
- No docs page exists at
docs/src/content/docs/reference/plugins/plugin-native-aac-encoder.md(every other plugin has one) marketplace/PORTABILITY_REVIEW.mddoesn't exist at all in the repo (so this checklist item may be aspirational).github/workflows/release.ymlhas no aac-related build prerequisites, yet the plugin requireslibfdk-aac.so.2at runtime
The commit message says "regenerate official-plugins.json for aac-encoder", suggesting this may be part of a multi-PR effort. The reviewer should verify whether the remaining checklist items are tracked elsewhere.
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
There was a problem hiding this comment.
This PR is scoped to fixing the CI failure caused by a stale official-plugins.json. The aac-encoder plugin was introduced in #266 — the remaining AGENTS.md checklist items (docs page, release workflow deps, etc.) are outside the scope of this fix and should be tracked separately.
Signed-off-by: StreamKit Devin <devin@streamkit.dev> Co-Authored-By: Claudio Costa <cstcld91@gmail.com>
2 participants
Summary
The
aac-encoderplugin was added in PR #266 butmarketplace/official-plugins.jsonwas not regenerated. This caused the "Verify official plugins metadata is current" CI step in the Marketplace Release workflow to fail (job link).This PR regenerates
marketplace/official-plugins.jsonviascripts/marketplace/generate_official_plugins.pyto include the newaac-encoderentry.Review & Testing Checklist for Human
aac-encoderentry inofficial-plugins.jsonmatches the plugin'splugin.ymlmetadataNotes
Low-risk metadata-only change. The file is fully auto-generated by
generate_official_plugins.py.Link to Devin session: https://staging.itsdev.in/sessions/b06b5b9799374229b9def639335b23b3
Requested by: @streamer45