Rename max_log_size to lifting_log_size. #1289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## leo/modify_build_weights_0 #1289 +/- ##
===========================================================
Coverage 91.97% 91.97%
===========================================================
Files 119 119
Lines 14966 14966
Branches 14966 14966
===========================================================
Hits 13765 13765
Misses 1111 1111
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leo-starkware
changed the base branch from
leo/modify_build_weights_0
to
graphite-base/1289
leo-starkware
force-pushed
the
leo/rename_max_log_size
branch
from
3131ad1 to
ccccd6f
Compare
leo-starkware
force-pushed
the
graphite-base/1289
branch
from
96610fa to
5221f96
Compare
leo-starkware
changed the base branch from
graphite-base/1289
to
leo/modify_build_weights_0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: ccccd6f | Previous: 3131ad1 | Ratio |
|---|---|---|---|
simd barycentric_eval_at_secure_field_point 2^20 |
977371 ns/iter (± 163124) |
424129 ns/iter (± 10964) |
2.30 |
This comment was automatically generated by workflow using github-action-benchmark.
leo-starkware
force-pushed
the
leo/modify_build_weights_0
branch
from
5221f96 to
55445cb
Compare
leo-starkware
changed the base branch from
leo/modify_build_weights_0
to
lifted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.