-
Notifications
You must be signed in to change notification settings - Fork 167
Fix non-parallel bugs. #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-parallel bugs. #1287
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lifted #1287 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 119 119
Lines 14958 14958
Branches 14958 14958
=======================================
Hits 13757 13757
Misses 1111 1111
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gali-StarkWare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can modify this PR to have only the lifted changes
@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
leo-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I will rebase lifted on dev after merging the pr on dev.
@leo-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
8c41adb to
0d033e1
Compare
cdc2ac7 to
47186dd
Compare
leo-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@leo-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
Gali-StarkWare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gali-StarkWare reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @leo-starkware).
crates/stwo/src/prover/backend/simd/quotients.rs line 150 at r2 (raw file):
#[cfg(not(feature = "parallel"))] let iter = domain_points;
Didn't work with .iter()? Interesting
Code quote:
let iter = domain_points;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 47186dd | Previous: cdc2ac7 | Ratio |
|---|---|---|---|
simd barycentric_eval_at_secure_field_point 2^20 |
1005287 ns/iter (± 56147) |
414479 ns/iter (± 8280) |
2.43 |
This comment was automatically generated by workflow using github-action-benchmark.

No description provided.