Skip to content

Conversation

@leo-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

leo-starkware commented Dec 21, 2025

@leo-starkware leo-starkware marked this pull request as ready for review December 21, 2025 08:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.97%. Comparing base (0d033e1) to head (47186dd).

Additional details and impacted files
@@           Coverage Diff           @@
##           lifted    #1287   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files         119      119           
  Lines       14958    14958           
  Branches    14958    14958           
=======================================
  Hits        13757    13757           
  Misses       1111     1111           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can modify this PR to have only the lifted changes

@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.

Copy link
Contributor Author

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I will rebase lifted on dev after merging the pr on dev.

@leo-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.

Copy link
Contributor Author

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@leo-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.

Copy link
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Gali-StarkWare reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @leo-starkware).


crates/stwo/src/prover/backend/simd/quotients.rs line 150 at r2 (raw file):

    #[cfg(not(feature = "parallel"))]
    let iter = domain_points;

Didn't work with .iter()? Interesting

Code quote:

let iter = domain_points;

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 47186dd Previous: cdc2ac7 Ratio
simd barycentric_eval_at_secure_field_point 2^20 1005287 ns/iter (± 56147) 414479 ns/iter (± 8280) 2.43

This comment was automatically generated by workflow using github-action-benchmark.

CC: @gilbens-starkware

@leo-starkware leo-starkware merged commit 53429cd into lifted Dec 21, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants