This repository was archived by the owner on Aug 21, 2024. It is now read-only.
fix: declare transaction error format #2069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2024
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/5ae2b059
branch
from
0f6df63 to
fe52aef
Compare
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/0f0f8dff
branch
from
7b10c29 to
23a4c77
Compare
dorimedini-starkware
previously approved these changes
Jul 14, 2024
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)
AvivYossef-starkware
changed the base branch from
spr/main-v0.13.2/0f0f8dff
to
main-v0.13.2
AvivYossef-starkware
dismissed
dorimedini-starkware’s stale review
The base branch was changed.
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/5ae2b059
branch
from
fe52aef to
c5bda03
Compare
AvivYossef-starkware
changed the base branch from
main-v0.13.2
to
spr/main-v0.13.2/2978d6d0
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/5ae2b059
branch
from
c5bda03 to
517c0b9
Compare
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/2978d6d0
branch
from
9848dc2 to
f02c316
Compare
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/5ae2b059
branch
from
517c0b9 to
f8878b9
Compare
dorimedini-starkware
previously approved these changes
Jul 14, 2024
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/5ae2b059
branch
from
f8878b9 to
410b547
Compare
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/2978d6d0
branch
from
920cb3e to
85d7b78
Compare
AvivYossef-starkware
changed the base branch from
spr/main-v0.13.2/2978d6d0
to
main-v0.13.2
AvivYossef-starkware
dismissed
dorimedini-starkware’s stale review
The base branch was changed.
commit-id:5ae2b059
AvivYossef-starkware
force-pushed
the
spr/main-v0.13.2/5ae2b059
branch
from
410b547 to
d886c11
Compare
dorimedini-starkware
approved these changes
Jul 15, 2024
Collaborator
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
This change is