fix: contract class version mismatch format

[AvivYossef-starkware]

Stack:

• fix: state error unavailable contract address format #2078
• fix: invalid nonce format #2073
• fix: invalid version format #2072
• fix: declare transaction error format #2069
• fix: contract class version mismatch format #2068 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[dorimedini-starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

crates/blockifier/src/transaction/errors.rs line 56 at r1 (raw file):

         version {cairo_version:?}.", **declare_version
    )]
    ContractClassVersionMismatch { declare_version: TransactionVersion, cairo_version: u64 },

why is this a u64 and not a CairoVersion enum instance?

Code quote:

cairo_version: u64

[AvivYossef-starkware]

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/errors.rs line 56 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why is this a u64 and not a CairoVersion enum instance?

good question it was u64 before

[AvivYossef-starkware]

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/errors.rs line 56 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

good question it was u64 before

Okay, it's because this enum in a test utils and cannot be compile in a non-test module. Should I move the enum to a diff module or keep it u64?

[dorimedini-starkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware)

---

crates/blockifier/src/transaction/errors.rs line 56 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

Okay, it's because this enum in a test utils and cannot be compile in a non-test module. Should I move the enum to a diff module or keep it u64?

hmm... keep it u64 but please add a TODO to move the def to a non-test area

[AvivYossef-starkware]

Closing pull request: commit has gone away