Skip to content

fix: Improve handling of HEAD requests when using hono plugin #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yolken-stainless merged 2 commits into from
Jan 9, 2026
Merged

fix: Improve handling of HEAD requests when using hono plugin #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f81eb6
Fix HEAD
yolken-stainless Jan 9, 2026
cc6d615
Also remove vitest
yolken-stainless Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/hono/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
/** @type {import('ts-jest/dist/types').InitialOptionsTsJest} */
module.exports = {
transform: {
"^.+\\.tsx?$": [
"ts-jest",
{
diagnostics: false,
isolatedModules: true,
},
],
},
testEnvironment: "node",
modulePathIgnorePatterns: ["<rootDir>/node_modules/", "/dist/"],
testPathIgnorePatterns: ["<rootDir>/node_modules/", "/dist/"],
testMatch: ["**/__tests__/**/*.test.[jt]s?(x)"],
setupFilesAfterEnv: [],
watchPathIgnorePatterns: ["<rootDir>/node_modules/"],
watchPlugins: [
"jest-watch-typeahead/filename",
"jest-watch-typeahead/testname",
],
verbose: false,
};
9 changes: 6 additions & 3 deletions packages/hono/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,16 @@
"main": "dist/honoPlugin.js",
"types": "dist/honoPlugin.d.ts",
"scripts": {
"clean": "rimraf dist *.tsbuildinfo"
"clean": "rimraf dist *.tsbuildinfo",
"test": "jest"
Copy link
Member

@cjquines cjquines Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: oops this was my bad. if we're going to use jest we should remove vitest in devdeps

Copy link
Contributor Author

@yolken-stainless yolken-stainless Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

},
"devDependencies": {
"@types/jest": "^29.5.10",
"@types/node": "^20.10.3",
"@types/qs": "^6.9.10",
"typescript": "^5.3.2",
"vitest": "^1.3.1"
"jest": "^29.7.0",
"ts-jest": "^29.1.1",
"typescript": "^5.3.2"
},
"dependencies": {
"hono": "^4.0.0",
Expand Down
19 changes: 12 additions & 7 deletions packages/hono/src/honoPlugin.test.ts → ...ges/hono/src/__tests__/honoPlugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { Hono } from "hono";
import { Stl, UnauthorizedError, z } from "stainless";
import { describe, expect, test } from "vitest";
import { stlApi } from "./honoPlugin";
import { stlApi } from "../honoPlugin";

const stl = new Stl({ plugins: {} });

Expand Down Expand Up @@ -63,9 +62,7 @@ describe("basic routing", () => {
test("list posts", async () => {
const response = await app.request("/api/posts");
expect(response).toHaveProperty("status", 200);
expect(await response.json()).toMatchInlineSnapshot(`
[]
`);
expect(await response.json()).toMatchInlineSnapshot("[]");
});

test("retrieve posts", async () => {
Expand All @@ -85,11 +82,19 @@ describe("basic routing", () => {
expect(response).toHaveProperty("status", 405);
expect(await response.json()).toMatchInlineSnapshot(`
{
"message": "No handler for PUT; only GET, POST.",
"message": "No handler for PUT; only GET, HEAD, POST.",
}
`);
});

test("head posts", async () => {
Copy link
Contributor Author

@yolken-stainless yolken-stainless Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails in main and passes with the fix.

const response = await app.request("/api/posts/5", {
method: "HEAD",
});
expect(response).toHaveProperty("status", 200);
expect(await response.text()).toBe("");
});

test("update posts", async () => {
const response = await app.request("/api/posts/5", {
method: "POST",
Expand Down Expand Up @@ -159,7 +164,7 @@ describe("basic routing", () => {
"received": "undefined",
},
],
"message": "Validation error: Required at "<body>.content"",
"message": "Required at "<body>.content"",
}
`);
});
Expand Down
5 changes: 5 additions & 0 deletions packages/hono/src/routeMatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ export function makeRouteMatcher(endpoints: AnyEndpoint[]) {
for (const endpoint of endpoints) {
const [method, path] = endpointToHono(endpoint.endpoint);
routeMatcher.add(method, path, endpoint);
if (method === "GET") {
Copy link
Contributor Author

@yolken-stainless yolken-stainless Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix.

// Hono route matching is method-specific, so also add a
// HEAD route for GET endpoints
routeMatcher.add("HEAD", path, endpoint);
}
}

return routeMatcher;
Expand Down
12 changes: 9 additions & 3 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.