fix: Improve handling of HEAD requests when using hono plugin#103
Merged
yolken-stainless merged 2 commits intomainfrom Jan 9, 2026
Merged
fix: Improve handling of HEAD requests when using hono plugin#103yolken-stainless merged 2 commits intomainfrom
yolken-stainless merged 2 commits intomainfrom
Conversation
yolken-stainless
commented
Jan 9, 2026
| `); | ||
| }); | ||
|
|
||
| test("head posts", async () => { |
Contributor
Author
There was a problem hiding this comment.
This test fails in main and passes with the fix.
yolken-stainless
commented
Jan 9, 2026
| for (const endpoint of endpoints) { | ||
| const [method, path] = endpointToHono(endpoint.endpoint); | ||
| routeMatcher.add(method, path, endpoint); | ||
| if (method === "GET") { |
Contributor
Author
There was a problem hiding this comment.
The actual fix.
cjquines
reviewed
Jan 9, 2026
| "scripts": { | ||
| "clean": "rimraf dist *.tsbuildinfo" | ||
| "clean": "rimraf dist *.tsbuildinfo", | ||
| "test": "jest" |
Member
There was a problem hiding this comment.
nit: oops this was my bad. if we're going to use jest we should remove vitest in devdeps
cjquines
approved these changes
Jan 9, 2026
yolken-stainless
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes the hono plugin so that it properly handles
HEADrequests; currently, these will result in a 405 error even though the underlying hono library supports them.This change also fixes the tests in the hono plugin package so they match the conventions of the other packages.
Testing
Testing completed successfully via extra unit tests.