-
Notifications
You must be signed in to change notification settings - Fork 69
Update x1_lite_lv schema validation #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
09da905
Add support for X1 Lite LV inverter
49f1e96
Fix incorrect PV power values in test sample data
c2c8510
Update x1_lite_lv schema validation
almost-online dcf0b97
Add support for multiple variants in X1 Lite LV inverter configuration
6568cdf
Merge remote-tracking branch 'origin/master'
d85c3eb
Add support for X1 Lite LV v002 and v005 variants
d40fd57
Refactor X1 Lite LV inverter parsing logic
e1e2f50
Update X1 Lite LV expected values and refactor KWH unit usage
2eaf8f2
Update `Hourly Energy` expected value in test data by 0.01 for consis…
dc19afe
Update X1 Lite LV expected values and fix unit handling for Total PV …
5dfabbb
Fix order of battery metrics in X1 Lite LV parser and expected values
66e9259
Update X1 Lite LV expected values: fix battery charge/discharge key o…
f5a8736
Comment out unused `inverter_versions_getter` method in X1 Lite LV in…
0234622
Remove unused log statement in `response_parser`.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has this changed from daily total to total?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this changes because had a warning from a HA.
So when I'll use the
DailyTotalthere I will get this warning:2025-09-12 10:39:09.320 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.solax_xxxxxxx_hourly_energy (<class 'custom_components.custom_solax.sensor.InverterSensorEntity'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise report it to the author of the 'solax' integrationaccording the
async_setup_entryfor the tupple lookup
SENSOR_DESCRIPTIONS[(measurement.unit, measurement.is_monotonic)]and this sensor setup
better to use the
Totalinstead ofDailyTotalthere or need to changefrom
to
But this is unsafe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, as a side note it looks like we never use
resets_daily? Wonder why I implemented that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the
TOTAL_INCREASEalso support thereset_dailystate value +sum