Update x1_lite_lv schema validation #196

almost-online · 2025-08-27T19:09:57Z

Fix schema validation error after a firmware update

Introduced the `X1LiteLV` class to handle X1 Lite LV inverter data and decoding logic. Updated the `__init__.py` and `setup.py` files to register the new inverter for system integration.

Adjusted the PV1 and PV2 power values in the test expected values to reflect accurate scaling. This ensures alignment with expected data and improves test reliability.

squishykid · 2025-08-27T19:16:54Z

If possible, do you have a sample response you can add as a test please?

# Conflicts: # solax/inverters/x1_lite_lv.py

almost-online · 2025-08-28T12:20:14Z

yes, sure
I will investigate whether some values are left as is or shifted, and then I will add a test case for a new data array.

Expanded the X1 Lite LV inverter support to include handling for the v002 and v005 variants. Updated test fixtures, expected values, and response data while refining parsing logic to accommodate additional features and variations.

Streamlined parsing methods and formatting in the `X1LiteLV` class. Updated test fixtures and sample responses for better clarity and structure.

Standardized energy unit handling in the `X1LiteLV` inverter class by removing `.value` for `Total(Units.KWH)` across all entries. Adjusted test expected values for consistency in key naming.

…tency

…Power Standardized Total PV Power unit to Watts in `X1LiteLV` inverter. Updated test expected values and sample responses to reflect corrected scaling and consistency.

…rder for consistency

…verter class for clarity.

almost-online · 2025-09-03T09:18:48Z

@squishykid

fix schema validations
added a test for a new firmware version
rename some properties
fixed units value

But I had an isue with run locally UT
e.g.
When use ./verify.sh got errors like

>       raise SocketBlockedError()
E       pytest_socket.SocketBlockedError: A test tried to use socket.socket.

with the pytest . --force-enable-socket got

file .venv/lib/python3.12/site-packages/pytest_homeassistant_custom_component/plugins.py, line 352
  @pytest.fixture(autouse=True)
  def enable_event_loop_debug(event_loop: asyncio.AbstractEventLoop) -> None:
E       fixture 'event_loop' not found

e.t.c.

that is why so many commits

Python 3.12.2

squishykid · 2025-09-09T10:43:12Z

No worries about the number of commits. It all gets squashed anyway. I’ll review this later today. From a glance it looks good though!

squishykid

Generally very PR, thank you for your attention to detail!

Two main questions, and these also have comments in the code:

Why have you chosen to rename some of the sensors?
Why have you chosen to edit one of the samples? For some context, they are there because they represent output from user inverters, so I need a really good reason for why we should change them. For example, I can imagine that your sensor renaming requires changes. Please share your thoughts on this.

Thanks again for your patience with all this, i'm sure we should be able to merge this soon!

solax/inverters/x1_lite_lv.py

squishykid · 2025-09-11T14:52:53Z

solax/inverters/x1_lite_lv.py

            # "Grid power 1": (33, Units.W, twoway_div10),
            # "Grid power 2": (34, Units.W, twoway_div10),
-            "Hourly Energy": (51, DailyTotal(Units.KWH), div100),
+            "Hourly Energy": (51, Total(Units.KWH), div100),


Why has this changed from daily total to total?

I did this changes because had a warning from a HA.
So when I'll use the DailyTotal there I will get this warning: 2025-09-12 10:39:09.320 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.solax_xxxxxxx_hourly_energy (<class 'custom_components.custom_solax.sensor.InverterSensorEntity'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise report it to the author of the 'solax' integration

according the async_setup_entry

for the tupple lookup
SENSOR_DESCRIPTIONS[(measurement.unit, measurement.is_monotonic)]

and this sensor setup

(Units.KWH, False): SensorEntityDescription( key=f"{Units.KWH}_{False}", device_class=SensorDeviceClass.ENERGY, native_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR, state_class=SensorStateClass.MEASUREMENT, ), (Units.KWH, True): SensorEntityDescription( key=f"{Units.KWH}_{True}", device_class=SensorDeviceClass.ENERGY, native_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR, state_class=SensorStateClass.TOTAL_INCREASING, ),

better to use the Total instead of DailyTotal there or need to change
from

class DailyTotal(Measurement):

to

class DailyTotal(Total):

But this is unsafe

Interesting, as a side note it looks like we never use resets_daily? Wonder why I implemented that.

But the TOTAL_INCREASE also support the reset_daily state value + sum

squishykid · 2025-09-11T14:53:13Z

solax/response_parser.py

        """

        raw_json = resp.decode("utf-8").replace(",,", ",0.0,").replace(",,", ",0.0,")
+        _LOGGER.info("Received response: %s", raw_json)


important: please remove this, it looks like a debugging artifact

almost-online

Thank you for the review

Two main questions, and these also have comments in the code:

Why have you chosen to rename some of the sensors?

I had rename some sensor in several reason:

a sensor naming convension (capitalize first letters, e.g. "AC current Out" -> "AC Current Out")
general right naming (e.g. 'Today's ...' -> 'Daily ...')
Naming related to the solax's data naming (e.g. "Today's Generated Energy" -> "Daily Inverter Output". see the screen below)

Why have you chosen to edit one of the samples? For some context, they are there because they represent output from user inverters, so I need a really good reason for why we should change them. For example, I can imagine that your sensor renaming requires changes. Please share your thoughts on this.

I'd just rename the X1_LITE_LV_80_RESPONSE to the X1_LITE_LV_80_v002_RESPONSE without any changes (for the old the 002 firmware version) + aded a new firmware version response (X1_LITE_LV_80_v005_RESPONSE for the 005 firmware version).

Probably misunderstanding with the expected value variable X1_LITE_LV_80_v002_VALUES

Thanks again for your patience with all this, i'm sure we should be able to merge this soon!
I hope so, thank you too!

solax/inverters/x1_lite_lv.py

almost-online · 2025-09-12T09:43:58Z

solax/inverters/x1_lite_lv.py

            # "Grid power 1": (33, Units.W, twoway_div10),
            # "Grid power 2": (34, Units.W, twoway_div10),
-            "Hourly Energy": (51, DailyTotal(Units.KWH), div100),
+            "Hourly Energy": (51, Total(Units.KWH), div100),


I did this changes because had a warning from a HA.
So when I'll use the DailyTotal there I will get this warning: 2025-09-12 10:39:09.320 WARNING (MainThread) [homeassistant.components.sensor] Entity sensor.solax_xxxxxxx_hourly_energy (<class 'custom_components.custom_solax.sensor.InverterSensorEntity'>) is using state class 'measurement' which is impossible considering device class ('energy') it is using; expected None or one of 'total', 'total_increasing'; Please update your configuration if your entity is manually configured, otherwise report it to the author of the 'solax' integration

according the async_setup_entry

for the tupple lookup
SENSOR_DESCRIPTIONS[(measurement.unit, measurement.is_monotonic)]

and this sensor setup

(Units.KWH, False): SensorEntityDescription( key=f"{Units.KWH}_{False}", device_class=SensorDeviceClass.ENERGY, native_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR, state_class=SensorStateClass.MEASUREMENT, ), (Units.KWH, True): SensorEntityDescription( key=f"{Units.KWH}_{True}", device_class=SensorDeviceClass.ENERGY, native_unit_of_measurement=UnitOfEnergy.KILO_WATT_HOUR, state_class=SensorStateClass.TOTAL_INCREASING, ),

better to use the Total instead of DailyTotal there or need to change
from

class DailyTotal(Measurement):

to

class DailyTotal(Total):

But this is unsafe

solax/inverters/x1_lite_lv.py

squishykid · 2025-09-12T13:57:47Z

Thank you for taking the time to respond to my questions. It feels clear to me now. I think you only need to remove the debug statement and then we can merge: #196 (comment)

Thank you for taking the time to work on this contribution!

almost-online

I'd already remove the _LOGGER artifact

Please, when you have time, merge the PR when it's ready

Thanks for reviewing!

almost-online · 2025-09-12T17:00:15Z

solax/inverters/x1_lite_lv.py

            # "Grid power 1": (33, Units.W, twoway_div10),
            # "Grid power 2": (34, Units.W, twoway_div10),
-            "Hourly Energy": (51, DailyTotal(Units.KWH), div100),
+            "Hourly Energy": (51, Total(Units.KWH), div100),


But the TOTAL_INCREASE also support the reset_daily state value + sum

squishykid · 2025-09-13T15:47:45Z

My bad on the debugger comment. I must have been looking at an old diff. Merge time!

Sergiy Andrusenko and others added 3 commits March 31, 2025 11:26

Add support for X1 Lite LV inverter

09da905

Introduced the `X1LiteLV` class to handle X1 Lite LV inverter data and decoding logic. Updated the `__init__.py` and `setup.py` files to register the new inverter for system integration.

Fix incorrect PV power values in test sample data

49f1e96

Adjusted the PV1 and PV2 power values in the test expected values to reflect accurate scaling. This ensures alignment with expected data and improves test reliability.

Update x1_lite_lv schema validation

c2c8510

Sergiy Andrusenko added 2 commits August 28, 2025 13:53

Add support for multiple variants in X1 Lite LV inverter configuration

dcf0b97

Merge remote-tracking branch 'origin/master'

6568cdf

# Conflicts: # solax/inverters/x1_lite_lv.py

Sergiy Andrusenko added 3 commits September 1, 2025 22:30

Add support for X1 Lite LV v002 and v005 variants

d85c3eb

Expanded the X1 Lite LV inverter support to include handling for the v002 and v005 variants. Updated test fixtures, expected values, and response data while refining parsing logic to accommodate additional features and variations.

Refactor X1 Lite LV inverter parsing logic

d40fd57

Streamlined parsing methods and formatting in the `X1LiteLV` class. Updated test fixtures and sample responses for better clarity and structure.

Update X1 Lite LV expected values and refactor KWH unit usage

e1e2f50

Standardized energy unit handling in the `X1LiteLV` inverter class by removing `.value` for `Total(Units.KWH)` across all entries. Adjusted test expected values for consistency in key naming.

almost-online marked this pull request as draft September 2, 2025 09:36

Sergiy Andrusenko added 5 commits September 2, 2025 13:04

Update Hourly Energy expected value in test data by 0.01 for consis…

2eaf8f2

…tency

Update X1 Lite LV expected values and fix unit handling for Total PV …

dc19afe

…Power Standardized Total PV Power unit to Watts in `X1LiteLV` inverter. Updated test expected values and sample responses to reflect corrected scaling and consistency.

Fix order of battery metrics in X1 Lite LV parser and expected values

5dfabbb

Update X1 Lite LV expected values: fix battery charge/discharge key o…

66e9259

…rder for consistency

Comment out unused inverter_versions_getter method in X1 Lite LV in…

f5a8736

…verter class for clarity.

almost-online marked this pull request as ready for review September 3, 2025 09:05

Remove unused log statement in response_parser.

0234622

squishykid requested changes Sep 11, 2025

View reviewed changes

almost-online commented Sep 12, 2025

View reviewed changes

almost-online commented Sep 13, 2025

View reviewed changes

squishykid merged commit 6c9e490 into squishykid:master Sep 13, 2025
6 checks passed

Update x1_lite_lv schema validation #196

Update x1_lite_lv schema validation #196

Uh oh!

Conversation

almost-online commented Aug 27, 2025

Uh oh!

squishykid commented Aug 27, 2025

Uh oh!

almost-online commented Aug 28, 2025

Uh oh!

almost-online commented Sep 3, 2025

Uh oh!

squishykid commented Sep 9, 2025

Uh oh!

squishykid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

squishykid Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

almost-online Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

squishykid Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

almost-online Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

squishykid Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

almost-online left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

almost-online Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

squishykid commented Sep 12, 2025

Uh oh!

almost-online left a comment

Choose a reason for hiding this comment

Uh oh!

almost-online Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

squishykid commented Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

squishykid commented Sep 13, 2025 •

edited

Loading