Skip to content

Clearer messaging in CLa / COC check #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kubabuczak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clearer messaging in CLa / COC check #1674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions .github/workflows/cla-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,33 @@ jobs:
PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
with:
path-to-signatures: "signatures/version1/cla.json"
path-to-document: "https://github.com/splunk/cla-agreement/blob/main/CLA.md" # e.g. a CLA or a DCO document
path-to-document: "https://github.com/splunk/cla-agreement/blob/main/CLA.md"
branch: "main"
allowlist: dependabot[bot]
remote-organization-name: splunk
remote-repository-name: cla-agreement
custom-notsigned-prcomment: "<br/>Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our [Contribution License Agreement](${input.getPathToDocument()}) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.<br/>"
Copy link
Collaborator

@rlieberman-splunk rlieberman-splunk Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the last sentence to say You can sign the CLA by just posting a Pull Request Comment with the exact sentence copied from below.? I think that is more clear.

custom-allsigned-prcomment: "⏳ **CLA signed** — now checking Code of Conduct status..."
CodeOfConduct:
runs-on: ubuntu-latest
# CLA and COC jobs both edit the same PR comment to show signing status.
# Run sequentially to avoid race conditions when updating the comment.
needs: ContributorLicenseAgreement
steps:
- name: "COC Assistant"
if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the Code of Conduct and I hereby accept the Terms') || github.event_name == 'pull_request_target'
if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the Code of Conduct and I hereby sign the COC') || github.event_name == 'pull_request_target'
uses: cla-assistant/github-action@v2.1.3-beta
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
with:
path-to-signatures: "signatures/version1/coc.json"
path-to-document: "https://github.com/splunk/cla-agreement/blob/main/CODE_OF_CONDUCT.md" # e.g. a COC or a DCO document
path-to-document: "https://github.com/splunk/cla-agreement/blob/main/CODE_OF_CONDUCT.md"
branch: "main"
allowlist: dependabot[bot]
remote-organization-name: splunk
remote-repository-name: cla-agreement
custom-pr-sign-comment: "I have read the Code of Conduct and I hereby accept the Terms"
create-file-commit-message: "For example: Creating file for storing COC Signatures"
custom-pr-sign-comment: "I have read the Code of Conduct and I hereby sign the COC"
signed-commit-message: "$contributorName has signed the COC in #$pullRequestNo"
custom-notsigned-prcomment: "All contributors have NOT signed the COC Document"
custom-allsigned-prcomment: "****CLA Assistant Lite bot**** All contributors have signed the COC ✍️ ✅"
custom-notsigned-prcomment: "<br/>🎉 **CLA signed — one more step to go!**<br/><br/>Please also accept our [Code of Conduct](${input.getPathToDocument()}) by posting a comment in the format below. This helps us maintain a welcoming community.<br/>"
Copy link
Collaborator

@rlieberman-splunk rlieberman-splunk Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the middle sentence to say by posting a comment with the exact sentence copied from below.? I think that is more clear.

custom-allsigned-prcomment: "All contributors have signed required documents ✍️ ✅"
Loading