Skip to content

Conversation

@kubabuczak
Copy link
Collaborator

Description

Make CLA & COC signing more clear

Key Changes

Clear communication about CLA and COC check
Avoid race condition

Testing and Verification

CLA & COC - TBH - I checked it with docuemtnation, it's hard to test it properly locally

Related Issues

N/A

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2026

Pull Request Test Coverage Report for Build 21294808175

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 86.557%

Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/afwscheduler.go 1 92.9%
pkg/splunk/enterprise/cp.go 1 33.33%
Totals Coverage Status
Change from base Build 21255354690: -0.02%
Covered Lines: 10708
Relevant Lines: 12371

💛 - Coveralls

allowlist: dependabot[bot]
remote-organization-name: splunk
remote-repository-name: cla-agreement
custom-notsigned-prcomment: "<br/>Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our [Contribution License Agreement](${input.getPathToDocument()}) before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.<br/>"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the last sentence to say You can sign the CLA by just posting a Pull Request Comment with the exact sentence copied from below.? I think that is more clear.

signed-commit-message: "$contributorName has signed the COC in #$pullRequestNo"
custom-notsigned-prcomment: "All contributors have NOT signed the COC Document"
custom-allsigned-prcomment: "****CLA Assistant Lite bot**** All contributors have signed the COC ✍️ ✅"
custom-notsigned-prcomment: "<br/>🎉 **CLA signed — one more step to go!**<br/><br/>Please also accept our [Code of Conduct](${input.getPathToDocument()}) by posting a comment in the format below. This helps us maintain a welcoming community.<br/>"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the middle sentence to say by posting a comment with the exact sentence copied from below.? I think that is more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants