Skip to content

Make reuse trigger cli args public #3402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fibonacci1729 merged 1 commit into from
Feb 17, 2026
Merged

Make reuse trigger cli args public #3402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/trigger-http/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ pub struct CliArgs {
/// e.g. 1..8. If it's a range, a number will be selected from that range
/// at random for each new instance.
#[clap(long, value_parser = parse_usize_range)]
max_instance_reuse_count: Option<Range<usize>>,
pub max_instance_reuse_count: Option<Range<usize>>,

/// Maximum number of concurrent requests to send to a single component
/// instance.
Expand All @@ -95,7 +95,7 @@ pub struct CliArgs {
/// e.g. 1..8. If it's a range, a number will be selected from that range
/// at random for each new instance.
#[clap(long, value_parser = parse_usize_range)]
max_instance_concurrent_reuse_count: Option<Range<usize>>,
pub max_instance_concurrent_reuse_count: Option<Range<usize>>,

/// Request timeout to enforce.
///
Expand All @@ -109,7 +109,7 @@ pub struct CliArgs {
/// e.g. 1..8s. If it's a range, a value will be selected from that range
/// at random for each new instance.
#[clap(long, value_parser = parse_duration_range)]
request_timeout: Option<Range<Duration>>,
pub request_timeout: Option<Range<Duration>>,

/// Time to hold an idle component instance for possible reuse before
/// dropping it.
Expand All @@ -122,7 +122,7 @@ pub struct CliArgs {
/// e.g. 1..8s. If it's a range, a value will be selected from that range
/// at random for each new instance.
#[clap(long, default_value = "1s", value_parser = parse_duration_range)]
idle_instance_timeout: Range<Duration>,
pub idle_instance_timeout: Range<Duration>,
}

impl CliArgs {
Expand All @@ -139,7 +139,7 @@ impl CliArgs {
}

#[derive(Copy, Clone)]
enum Range<T> {
pub enum Range<T> {
Value(T),
Bounds(T, T),
}
Expand Down